Lots of empty region after restore

[overvenus]

Region size is not updated during BR restore, this is because we forget to set Length of SSTMeta.

br/pkg/restore/util.go

Lines 140 to 149 in 008ec45

	return import_sstpb.SSTMeta{
	Uuid: id,
	CfName: cfName,
	Range: &import_sstpb.Range{
	Start: rangeStart,
	End: rangeEnd,
	},
	RegionId: region.GetId(),
	RegionEpoch: region.GetRegionEpoch(),
	}

The Length means the length of the SST file, so TiKV should record it during backup as requested in #95 .

[kennytm]

This is a bug in BR only right? The Files in the BackupResponse already contained the size.

https://github.com/pingcap/kvproto/blob/dba161a41fd2edfe1349a7c7322276640642633d/proto/backup.proto#L63

[overvenus]

TiKV has not filled it yet, so we need to touch TiKV too.

[kennytm]

Ah ok.