Skip to content

Commit 4632c3e

Browse files
GadgetoidGadgetoid
authored
Merge pull request #26 from pimoroni/patch-bitrot
Update tests and Python versions.
2 parents b84edda + f35f92b commit 4632c3e

39 files changed

+552
-826
lines changed

‎.github/workflows/build.yml

+41
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,41 @@
1+
name: Build
2+
3+
on:
4+
pull_request:
5+
push:
6+
branches:
7+
- main
8+
9+
jobs:
10+
test:
11+
name: Python ${{ matrix.python }}
12+
runs-on: ubuntu-latest
13+
strategy:
14+
matrix:
15+
python: ['3.9', '3.10', '3.11']
16+
17+
env:
18+
RELEASE_FILE: ${{ github.event.repository.name }}-${{ github.event.release.tag_name || github.sha }}-py${{ matrix.python }}
19+
20+
steps:
21+
- name: Checkout Code
22+
uses: actions/checkout@v3
23+
24+
- name: Set up Python ${{ matrix.python }}
25+
uses: actions/setup-python@v3
26+
with:
27+
python-version: ${{ matrix.python }}
28+
29+
- name: Install Dependencies
30+
run: |
31+
make dev-deps
32+
33+
- name: Build Packages
34+
run: |
35+
make build
36+
37+
- name: Upload Packages
38+
uses: actions/upload-artifact@v3
39+
with:
40+
name: ${{ env.RELEASE_FILE }}
41+
path: dist/

‎.github/workflows/qa.yml

+36
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,36 @@
1+
name: QA
2+
3+
on:
4+
pull_request:
5+
push:
6+
branches:
7+
- main
8+
9+
jobs:
10+
test:
11+
name: linting & spelling
12+
runs-on: ubuntu-latest
13+
14+
env:
15+
TERM: xterm-256color
16+
17+
steps:
18+
- name: Checkout Code
19+
uses: actions/checkout@v2
20+
21+
- name: Set up Python '3,11'
22+
uses: actions/setup-python@v3
23+
with:
24+
python-version: '3.11'
25+
26+
- name: Install Dependencies
27+
run: |
28+
make dev-deps
29+
30+
- name: Run Quality Assurance
31+
run: |
32+
make qa
33+
34+
- name: Run Code Checks
35+
run: |
36+
make check

‎.github/workflows/test.yml

+14-11
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
name: Python Tests
1+
name: Tests
22

33
on:
44
pull_request:
@@ -8,30 +8,33 @@ on:
88

99
jobs:
1010
test:
11+
name: Python ${{ matrix.python }}
1112
runs-on: ubuntu-latest
1213
strategy:
1314
matrix:
14-
python: [3.6, 3.7, 3.8, 3.9]
15+
python: ['3.9', '3.10', '3.11']
1516

1617
steps:
17-
- uses: actions/checkout@v2
18+
- name: Checkout Code
19+
uses: actions/checkout@v3
20+
1821
- name: Set up Python ${{ matrix.python }}
19-
uses: actions/setup-python@v2
22+
uses: actions/setup-python@v3
2023
with:
2124
python-version: ${{ matrix.python }}
25+
2226
- name: Install Dependencies
2327
run: |
24-
python -m pip install --upgrade setuptools tox
28+
make dev-deps
29+
2530
- name: Run Tests
26-
working-directory: library
2731
run: |
28-
tox -e py
32+
make pytest
33+
2934
- name: Coverage
35+
if: ${{ matrix.python == '3.9' }}
3036
env:
3137
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
32-
working-directory: library
3338
run: |
3439
python -m pip install coveralls
35-
coveralls --service=github
36-
if: ${{ matrix.python == '3.9' }}
37-
40+
coveralls --service=github

‎.stickler.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -2,4 +2,4 @@
22
linters:
33
flake8:
44
python: 3
5-
max-line-length: 160
5+
max-line-length: 160

‎.travis.yml

-25
This file was deleted.

‎CHANGELOG.md

+11
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,11 @@
1+
0.0.2
2+
-----
3+
4+
* Values will now always be float
5+
* Fixed backlight pin
6+
* Fixed latest/average mph
7+
8+
0.0.1
9+
-----
10+
11+
* Initial Release

‎Makefile

+40-50
Original file line numberDiff line numberDiff line change
@@ -1,70 +1,60 @@
1-
LIBRARY_VERSION=$(shell grep version library/setup.cfg | awk -F" = " '{print $$2}')
2-
LIBRARY_NAME=$(shell grep name library/setup.cfg | awk -F" = " '{print $$2}')
1+
LIBRARY_NAME := $(shell hatch project metadata name 2> /dev/null)
2+
LIBRARY_VERSION := $(shell hatch version 2> /dev/null)
33

4-
.PHONY: usage install uninstall
4+
.PHONY: usage install uninstall check pytest qa build-deps check tag wheel sdist clean dist testdeploy deploy
55
usage:
6+
ifdef LIBRARY_NAME
67
@echo "Library: ${LIBRARY_NAME}"
78
@echo "Version: ${LIBRARY_VERSION}\n"
9+
else
10+
@echo "WARNING: You should 'make dev-deps'\n"
11+
endif
812
@echo "Usage: make <target>, where target is one of:\n"
9-
@echo "install: install the library locally from source"
10-
@echo "uninstall: uninstall the local library"
11-
@echo "check: peform basic integrity checks on the codebase"
12-
@echo "python-readme: generate library/README.md from README.md + library/CHANGELOG.txt"
13-
@echo "python-wheels: build python .whl files for distribution"
14-
@echo "python-sdist: build python source distribution"
15-
@echo "python-clean: clean python build and dist directories"
16-
@echo "python-dist: build all python distribution files"
17-
@echo "python-testdeploy: build all and deploy to test PyPi"
18-
@echo "tag: tag the repository with the current version"
13+
@echo "install: install the library locally from source"
14+
@echo "uninstall: uninstall the local library"
15+
@echo "dev-deps: install Python dev dependencies"
16+
@echo "check: perform basic integrity checks on the codebase"
17+
@echo "qa: run linting and package QA"
18+
@echo "pytest: run Python test fixtures"
19+
@echo "clean: clean Python build and dist directories"
20+
@echo "build: build Python distribution files"
21+
@echo "testdeploy: build and upload to test PyPi"
22+
@echo "deploy: build and upload to PyPi"
23+
@echo "tag: tag the repository with the current version\n"
1924

2025
install:
21-
./install.sh
26+
./install.sh --unstable
2227

2328
uninstall:
2429
./uninstall.sh
2530

26-
check:
27-
@echo "Checking for trailing whitespace"
28-
@! grep -IUrn --color "[[:blank:]]$$" --exclude-dir=sphinx --exclude-dir=.tox --exclude-dir=.git --exclude=PKG-INFO
29-
@echo "Checking for DOS line-endings"
30-
@! grep -lIUrn --color "" --exclude-dir=sphinx --exclude-dir=.tox --exclude-dir=.git --exclude=Makefile
31-
@echo "Checking library/CHANGELOG.txt"
32-
@cat library/CHANGELOG.txt | grep ^${LIBRARY_VERSION}
33-
@echo "Checking library/${LIBRARY_NAME}/__init__.py"
34-
@cat library/${LIBRARY_NAME}/__init__.py | grep "^__version__ = '${LIBRARY_VERSION}'"
35-
36-
tag:
37-
git tag -a "v${LIBRARY_VERSION}" -m "Version ${LIBRARY_VERSION}"
31+
dev-deps:
32+
python3 -m pip install -r requirements-dev.txt
33+
sudo apt install dos2unix
3834

39-
python-readme: library/README.md
40-
41-
python-license: library/LICENSE.txt
35+
check:
36+
@bash check.sh
4237

43-
library/README.md: README.md library/CHANGELOG.txt
44-
cp README.md library/README.md
45-
printf "\n# Changelog\n" >> library/README.md
46-
cat library/CHANGELOG.txt >> library/README.md
38+
qa:
39+
tox -e qa
4740

48-
library/LICENSE.txt: LICENSE
49-
cp LICENSE library/LICENSE.txt
41+
pytest:
42+
tox -e py
5043

51-
python-wheels: python-readme python-license
52-
cd library; python3 setup.py bdist_wheel
53-
cd library; python setup.py bdist_wheel
44+
nopost:
45+
@bash check.sh --nopost
5446

55-
python-sdist: python-readme python-license
56-
cd library; python setup.py sdist
47+
tag:
48+
git tag -a "v${LIBRARY_VERSION}" -m "Version ${LIBRARY_VERSION}"
5749

58-
python-clean:
59-
-rm -r library/dist
60-
-rm -r library/build
61-
-rm -r library/*.egg-info
50+
build: check
51+
@hatch build
6252

63-
python-dist: python-clean python-wheels python-sdist
64-
ls library/dist
53+
clean:
54+
-rm -r dist
6555

66-
python-testdeploy: python-dist
67-
twine upload --repository-url https://test.pypi.org/legacy/ library/dist/*
56+
testdeploy: build
57+
twine upload --repository testpypi dist/*
6858

69-
python-deploy: check python-dist
70-
twine upload library/dist/*
59+
deploy: nopost build
60+
twine upload dist/*

‎README.md

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
# Weather HAT Python Library & Examples
22

3-
[![Build Status](https://shields.io/github/workflow/status/pimoroni/weatherhat-python/Python%20Tests.svg)](https://github.com/pimoroni/weatherhat-python/actions/workflows/test.yml)
3+
[![Build Status](https://img.shields.io/github/actions/workflow/status/pimoroni/weatherhat-python/test.yml?branch=main)](https://github.com/pimoroni/weatherhat-python/actions/workflows/test.yml)
44
[![Coverage Status](https://coveralls.io/repos/github/pimoroni/weatherhat-python/badge.svg?branch=master)](https://coveralls.io/github/pimoroni/weatherhat-python?branch=master)
55
[![PyPi Package](https://img.shields.io/pypi/v/weatherhat.svg)](https://pypi.python.org/pypi/weatherhat)
66
[![Python Versions](https://img.shields.io/pypi/pyversions/weatherhat.svg)](https://pypi.python.org/pypi/weatherhat)
@@ -28,7 +28,7 @@ Latest/development library from GitHub:
2828

2929
* `git clone https://github.com/pimoroni/weatherhat-python`
3030
* `cd weatherhat-python`
31-
* `sudo ./install.sh`
31+
* `./install.sh --unstable`
3232

3333
Some of the examples use additional libraries. You can install them with:
3434

‎check.sh

+87
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,87 @@
1+
#!/bin/bash
2+
3+
# This script handles some basic QA checks on the source
4+
5+
NOPOST=$1
6+
LIBRARY_NAME=`hatch project metadata name`
7+
LIBRARY_VERSION=`hatch version | awk -F "." '{print $1"."$2"."$3}'`
8+
POST_VERSION=`hatch version | awk -F "." '{print substr($4,0,length($4))}'`
9+
10+
success() {
11+
echo -e "$(tput setaf 2)$1$(tput sgr0)"
12+
}
13+
14+
inform() {
15+
echo -e "$(tput setaf 6)$1$(tput sgr0)"
16+
}
17+
18+
warning() {
19+
echo -e "$(tput setaf 1)$1$(tput sgr0)"
20+
}
21+
22+
while [[ $# -gt 0 ]]; do
23+
K="$1"
24+
case $K in
25+
-p|--nopost)
26+
NOPOST=true
27+
shift
28+
;;
29+
*)
30+
if [[ $1 == -* ]]; then
31+
printf "Unrecognised option: $1\n";
32+
exit 1
33+
fi
34+
POSITIONAL_ARGS+=("$1")
35+
shift
36+
esac
37+
done
38+
39+
inform "Checking $LIBRARY_NAME $LIBRARY_VERSION\n"
40+
41+
inform "Checking for trailing whitespace..."
42+
grep -IUrn --color "[[:blank:]]$" --exclude-dir=dist --exclude-dir=.tox --exclude-dir=.git --exclude=PKG-INFO
43+
if [[ $? -eq 0 ]]; then
44+
warning "Trailing whitespace found!"
45+
exit 1
46+
else
47+
success "No trailing whitespace found."
48+
fi
49+
printf "\n"
50+
51+
inform "Checking for DOS line-endings..."
52+
grep -lIUrn --color $'\r' --exclude-dir=dist --exclude-dir=.tox --exclude-dir=.git --exclude=Makefile
53+
if [[ $? -eq 0 ]]; then
54+
warning "DOS line-endings found!"
55+
exit 1
56+
else
57+
success "No DOS line-endings found."
58+
fi
59+
printf "\n"
60+
61+
inform "Checking CHANGELOG.md..."
62+
cat CHANGELOG.md | grep ^${LIBRARY_VERSION} > /dev/null 2>&1
63+
if [[ $? -eq 1 ]]; then
64+
warning "Changes missing for version ${LIBRARY_VERSION}! Please update CHANGELOG.md."
65+
exit 1
66+
else
67+
success "Changes found for version ${LIBRARY_VERSION}."
68+
fi
69+
printf "\n"
70+
71+
inform "Checking for git tag ${LIBRARY_VERSION}..."
72+
git tag -l | grep -E "${LIBRARY_VERSION}$"
73+
if [[ $? -eq 1 ]]; then
74+
warning "Missing git tag for version ${LIBRARY_VERSION}"
75+
fi
76+
printf "\n"
77+
78+
if [[ $NOPOST ]]; then
79+
inform "Checking for .postN on library version..."
80+
if [[ "$POST_VERSION" != "" ]]; then
81+
warning "Found .$POST_VERSION on library version."
82+
inform "Please only use these for testpypi releases."
83+
exit 1
84+
else
85+
success "OK"
86+
fi
87+
fi

0 commit comments

Comments
 (0)