Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

codeCheck() considers main.gms part of core #38

Open
0UmfHxcvx5J7JoaOhFSs5mncnisTJJ6q opened this issue Oct 18, 2022 · 3 comments
Open
Assignees
Labels
bug Something isn't working

Comments

@0UmfHxcvx5J7JoaOhFSs5mncnisTJJ6q
Copy link
Member

If one defines a parameter/variable in main.gms to configure the behaviour of a specific module, it has to be named cm_ instead of c123_ for codeCheck() to succeed. That is counter-intuitive and reduces lucidity, as elements used only in one module look as if they were relevant to core as well.
As an example, check cm_indst_H2costAddH2Inv in REMIND, which could be renamed c37_indst_H2costAddH2Inv if codeCheck() would get this right.

@0UmfHxcvx5J7JoaOhFSs5mncnisTJJ6q 0UmfHxcvx5J7JoaOhFSs5mncnisTJJ6q added the bug Something isn't working label Oct 18, 2022
@tscheypidi
Copy link
Member

This is the intended behavior as everything which is not part of a module is part of core. If you want to use c37_... instead of cm_..... you can declare the parameter/variable directly in the corresponding module. See for instance here

@0UmfHxcvx5J7JoaOhFSs5mncnisTJJ6q
Copy link
Member Author

If you want to use c37_... instead of cm_..... you can declare the parameter/variable directly in the corresponding module. See for instance here

And there are facilities to configure those variables without changing version-controlled files?

@mikapfl
Copy link
Contributor

mikapfl commented Oct 20, 2022

This is a case of different use cases in REMIND and MAgPIE, I'll look into it.

@mikapfl mikapfl reopened this Oct 20, 2022
@mikapfl mikapfl self-assigned this Oct 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants