Check ETH balance before sending external call

pie-dao · Dec 7, 2020 · fbe2173 · fbe2173
1 parent 5034462
commit fbe2173
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 0 deletions.
diff --git a/contracts/facets/Call/CallFacet.sol b/contracts/facets/Call/CallFacet.sol
@@ -99,6 +99,7 @@ contract CallFacet is ReentryProtection, ICallFacet {
     bytes memory _calldata,
     uint256 _value
   ) internal {
+    require(address(this).balance >= _value, "ETH_BALANCE_TOO_LOW");
     (bool success, ) = _target.call{ value: _value }(_calldata);
     require(success, "CALL_FAILED");
     emit Call(_target, _calldata, _value);

diff --git a/test/call.ts b/test/call.ts
@@ -129,6 +129,19 @@ describe("CallFacet", function() {
             const difference = userBalanceAfter.sub(userBalanceBefore);
             expect(difference).to.eq(parseEther("9"));
         });
+        it("Sending ether while not having enough balance should throw an error", async() => {
+            let ether = await ethers.provider.getBalance(experiPie.address);
+            expect(ether).to.eq("0");
+
+            await signers[0].sendTransaction({to: experiPie.address, value: parseEther("10")});
+
+            ether = await ethers.provider.getBalance(experiPie.address);
+            expect(ether).to.eq(parseEther("10"));
+
+            const user = await signers[4].getAddress();
+
+            await expect(experiPie.call([user], ["0x00"], [parseEther("10.1")])).to.be.revertedWith("ETH_BALANCE_TOO_LOW");
+        });
         it("Send contract erc20 token", async () => {
             let balance = await testTokens[0].balanceOf(experiPie.address);
             expect(balance).to.eq(0);