New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce timeout wait time #215

Merged

phstc merged 1 commit into ruby-shoryuken:master from mariokostelac:mario/fix_timeout

Jun 2, 2016

Contributor

mariokostelac commented May 25, 2016 •

edited

Loading

Fixes that case where:

Timeout is set to some big value (slow jobs needs that to avoid excessive retrying)
stop is received
A worker is running so we end in after(delay) part of soft/hard shutdown

Current code will wait for exactly delay to shut down while it could die after that last worker crashes/finishes.

mariokostelac force-pushed the mario/fix_timeout branch from 4584f07 to ae24c25 Compare

May 25, 2016 15:53

mariokostelac changed the title ~~Reduce hard timeout wait time~~ Reduce timeout wait time


          Reduce shutdown wait time

29a3624

mariokostelac force-pushed the mario/fix_timeout branch from ae24c25 to 29a3624 Compare

May 25, 2016 15:56

mariokostelac mentioned this pull request

Make fetcher pause interval configurable #214

Closed

phstc merged commit 12f0151 into ruby-shoryuken:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet