Fix scrutinizer violations

phpmd · Apr 2, 2021 · aa6de32 · aa6de32
1 parent e910232
commit aa6de32
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 9 deletions.
diff --git a/src/test/php/PHPMD/Renderer/BaselineRendererTest.php b/src/test/php/PHPMD/Renderer/BaselineRendererTest.php
@@ -24,8 +24,7 @@ public function testRenderReport()
         );
 
         $report = $this->getReportWithNoViolation();
-        $report->expects(static::once())
-            ->method('getRuleViolations')
+        $report->method('getRuleViolations')
             ->willReturn(new ArrayIterator($violations));
 
         $renderer = new BaselineRenderer('/src');
@@ -47,7 +46,7 @@ public function testRenderReportShouldWriteMethodName()
     {
         $writer        = new WriterStub();
         $violationMock = $this->getRuleViolationMock('/src/php/bar.php');
-        $violationMock->expects(static::once())->method('getMethodName')->willReturn('foo');
+        $violationMock->method('getMethodName')->willReturn('foo');
 
         $report = $this->getReportWithNoViolation();
         $report->expects(static::once())
@@ -77,8 +76,7 @@ public function testRenderReportShouldDeduplicateSimilarViolations()
 
         // add the same violation twice
         $report = $this->getReportWithNoViolation();
-        $report->expects(static::once())
-            ->method('getRuleViolations')
+        $report->method('getRuleViolations')
             ->willReturn(new ArrayIterator(array($violationMock, $violationMock)));
 
         $renderer = new BaselineRenderer('/src');
@@ -100,8 +98,7 @@ public function testRenderEmptyReport()
     {
         $writer = new WriterStub();
         $report = $this->getReportWithNoViolation();
-        $report->expects(static::once())
-            ->method('getRuleViolations')
+        $report->method('getRuleViolations')
             ->willReturn(new ArrayIterator(array()));
 
         $renderer = new BaselineRenderer('/src');

diff --git a/src/test/php/PHPMD/ReportTest.php b/src/test/php/PHPMD/ReportTest.php
@@ -195,9 +195,9 @@ public function testGetErrorsReturnsPreviousAddedProcessingError()
      */
     public function testReportShouldIgnoreBaselineViolation()
     {
-        /** @var RuleViolation|PHPUnit_Framework_MockObject_MockObject $ruleA */
+        /** @var RuleViolation $ruleA */
         $ruleA = $this->getRuleViolationMock('foo.txt');
-        /** @var RuleViolation|PHPUnit_Framework_MockObject_MockObject $ruleB */
+        /** @var RuleViolation $ruleB */
         $ruleB = $this->getRuleViolationMock('bar.txt', 1, 2);
 
         // setup baseline