Remove data-element attribute (#440)

g105b · web-flow · commit 6829c86a4258 · 2023-07-19T11:36:13.000+01:00
* build: upgrade dom requirement and loosen version range * docs: update examples * feature: trim whitespace when there are only template children closes #363 * maintenance: phpstorm analysis improvements * feature: remove unbound elements that are marked accordingly closes #438 * test: ensure element does not get removed after bound for #438 * feature: use `data-element` attribute for #438 * tweak: remove data-element attribute
diff --git a/src/DocumentBinder.php b/src/DocumentBinder.php
@@ -151,6 +151,10 @@ public function cleanupDocument():void {
 
 			$item->ownerElement->removeAttribute($item->name);
 		}
+
+		foreach($this->document->querySelectorAll("[data-element]") as $dataElement) {
+			$dataElement->removeAttribute("data-element");
+		}
 	}
 
 	private function bind(

Original file line number	Diff line number	Diff line change
`@@ -151,6 +151,10 @@ public function cleanupDocument():void {`
`151`	`151`
`152`	`152`	`$item->ownerElement->removeAttribute($item->name);`
`153`	`153`	`}`
	`154`	`+`
	`155`	`+ foreach($this->document->querySelectorAll("[data-element]") as $dataElement) {`
	`156`	`+ $dataElement->removeAttribute("data-element");`
	`157`	`+ }`
`154`	`158`	`}`
`155`	`159`
`156`	`160`	`private function bind(`