From 396ffdc77bb4fe1b7621606a6413914e29446359 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Viktor=20Sz=C3=A9pe?= Date: Mon, 6 Mar 2023 10:03:40 +0100 Subject: [PATCH 1/2] Improve getNodeName --- visitor.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/visitor.php b/visitor.php index 08e93a1..b6c2bdf 100644 --- a/visitor.php +++ b/visitor.php @@ -307,7 +307,7 @@ public function enterNode(Node $node) private static function getNodeName(Node $node): string { - if ((($node instanceof Function_) || ($node instanceof ClassMethod) || ($node instanceof Class_)) && $node->name instanceof Identifier) { + if ($node instanceof Function_ || $node instanceof ClassMethod || ($node instanceof Class_ && $node->name instanceof Identifier)) { return $node->name->name; } From bf360e036f05ccb284e5e15a6be4928071cfe629 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Viktor=20Sz=C3=A9pe?= Date: Mon, 6 Mar 2023 10:08:51 +0100 Subject: [PATCH 2/2] debug --- visitor.php | 2 ++ 1 file changed, 2 insertions(+) diff --git a/visitor.php b/visitor.php index b6c2bdf..5573d3b 100644 --- a/visitor.php +++ b/visitor.php @@ -308,6 +308,8 @@ public function enterNode(Node $node) private static function getNodeName(Node $node): string { if ($node instanceof Function_ || $node instanceof ClassMethod || ($node instanceof Class_ && $node->name instanceof Identifier)) { + \PHPStan\dumpType($node); + \PHPStan\dumpType($node->name); return $node->name->name; }