Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Plugin ID #311

Closed
nico-loeber opened this issue Apr 9, 2024 · 6 comments
Closed

Change Plugin ID #311

nico-loeber opened this issue Apr 9, 2024 · 6 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@nico-loeber
Copy link
Contributor

"intellij" is no longer allowed to be part of the plugin id. The current plugin id is "de.php_perfect.intellij.ddev".
The plugin id is used many times in the plugin and all services ids are prefixed with this id. It has to be changed to something like "de.php_perfect.ddev_integration" and all packages and services need to be renamed.

This is requirment to publish a new version.

@nico-loeber nico-loeber added good first issue Good for newcomers help wanted Extra attention is needed labels Apr 9, 2024
@Aneida
Copy link
Contributor

Aneida commented Apr 10, 2024

I found this: https://intellij-support.jetbrains.com/hc/en-us/community/posts/13362061756050/comments/13368843442834

@mavolkmer
Copy link

reads to me like there is no need for changing plugin-id for an already published plugin - so this issue could be closed (?)

@nico-loeber
Copy link
Contributor Author

Thanks for looking into this @Aneida!
I don't think we can close this issue, as it is still an issue that prevents creating a new release. The job does fail with this error.
Maybe we can just skip the validator for now, but this would only be a temporary fix.

@AkibaAT
Copy link
Collaborator

AkibaAT commented Aug 20, 2024

While the plugin verifier itself provides the -mute TemplateWordInPluginId to ignore the check, the pluginVerification Gradle config has no option for setting any mute flags.

@wp4nuv
Copy link

wp4nuv commented Aug 22, 2024

I came across the plugin incompatibility with PHPStorm version 2024.2 and after researching a bit, this issue has been reported via YouTrack: https://youtrack.jetbrains.com/issue/MP-5911/Not-expected-plugin-verifier-warning-for-plugin-ID-containing-intellij

What's concerning is there are multiple devs complaining about the issue and this ticket has been closed as "Fixed". I wonder if what JetBrains may be saying, albeit silently, is for plugin devs to remove their plugins from the Marketplace, make the id compatible, then republish.

This, of course, sounds unacceptable, particularly for long established plugins. It would be very disrupting to the community. Has anyone had experience reaching out to JetBrains outside of YouTrack as a plugin developer?

@nico-loeber
Copy link
Contributor Author

As already mentioned, the ID should not be changed, so I will close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
Status: Done
Development

No branches or pull requests

5 participants