Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chromatic parameter not available in FSIM loss #145

Closed
zakajd opened this issue Jul 20, 2020 · 0 comments · Fixed by #146
Closed

chromatic parameter not available in FSIM loss #145

zakajd opened this issue Jul 20, 2020 · 0 comments · Fixed by #146
Labels
bug Something isn't working

Comments

@zakajd
Copy link
Collaborator

zakajd commented Jul 20, 2020

Describe the bug
During initial PR #109 I forgot to add chromatic parameter` to the loss. So now only greyscale option is supported.

To Reproduce

  1. from piq import FSIMLoss
  2. loss = FSIMLoss(chromatic=True)
  3. See error

Expected behavior
Same features should be available in FSIMLoss as in fsim function.
@zakajd zakajd added the bug Something isn't working label Jul 20, 2020
@zakajd zakajd mentioned this issue Jul 20, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add chromatic param to FSIM loss photosynthesis-team/piq
1 participant
@zakajd