-
Notifications
You must be signed in to change notification settings - Fork 1.9k
GCM bitcode errors #446
Comments
@code-smith not currently. What I want to do is to move the GCM stuff on iOS to a cocoapod but I need to get Cordova/PhoneGap to support it as a framework first. |
Ok, but I really think including gcm is very messy as its giving all these build warnings..and we need to disable bitcode. |
@code-smith No, I haven't run into a problem with Apple with a bitcode disabled app. In fact we just got approval for one last week. I fully admit that the GCM code in iOS is messy, I even mention that in the issue itself. I have a plan to clean it up but it will require some changes to Cordova/PhoneGap as well. However GCM on iOS was requested a bunch of times so I wanted to enable people to start using it. |
@macdonst You just released a lot of stress that was building up. Thanks for answering. I wrote myself some code for using parse push notification and ran in to some problem and raised another issue i raised, #447. I dont understand the point of the method notification_applicationDidBecomeActive, when its not getting called. |
@macdonst i dont know how to leave a personal message to you , please consider this as pm . |
@code-smith if your app isn't compiling with bit code enabled then turn it off. This SO post is much better at explaining it than I would ever be. Check the first 2 answers: http://stackoverflow.com/questions/31088618/impact-of-xcode-build-options-enable-bitcode-yes-no |
I did disable bitcode in xcode. |
I have the same problem when i try to build on my iPhone device (Simulator OK)... ...Plugins/phonegap-plugin-push/GCM/Libraries/libGGLCloudMessaging.a(GGLContext+CloudMessaging.o)' does not contain bitcode. You must rebuild it with bitcode enabled (Xcode setting ENABLE_BITCODE), obtain an updated library from the vendor, or disable bitcode for this target. for architecture armv7 @macdonst As I understand it , you can not correct this problem because the solution is not simple ? |
@flashnet69 Just turn bitcode off. I need a new lib from Google in order to fix that bitcode issue. |
I don't if it's could be a solution but maybe you can delete all the GCM related files and reference in the generated Xcode project when you build iOS? |
If google/gcm#91 gets fixed, this issue could be more easily fixed, right? |
Besides that, could I help in some way here @macdonst? I've written plugins in the past (actually, I think the first and last plugin I wrote were push plugins :)), and I've patched my own cordova a few times (back on v0 and v1). If there's anything I could do to help here, I'm all ears(?/eyes?). I have an upcoming release window (next week) where I need to release action button support on Apple Watch (so I need bitcode support) and I have two options:
Unless you tell me there isn't a chance that we can get it done in ~7 days, I still think it's worth a try :) It seems easy to just remove GCM, but it's a very worthless use of time, because we could use that same (probably more) effort to really get this fixed. Worst case, I can rush to remove GCM on Monday if we can't reach estimated goals until then. |
@panaggio yeah, once google/gcm#91 is fixed then this problem will go away. Sorry, I have been out of touch as I was on vacation. If you have already gone and removed GCM in a fork please let me know via a PR to a new branch. I'm thinking of maintaining a branch with out GCM iOS support as it causes problems for a bunch of people. |
Np.
I', not there yet. I'm having some issues, and AFAICS it isn't on the fork itself, but it could be. As soon as the fork works properly, I'll create the PR. Anyway, I'm still up to helping fix the plugin. Let me know if I can be of help. |
google/gcm#91 has been fixed 2016-04-22. Is it now enough to increase phonegap-plugin-push version? |
@bjakubiak it got fixed but I don't see an update on CocoaPods. The latest version is from back before the bug was fixed. |
@macdonst have any release date for this fix? |
@arthuralves last cocoapod release of GCM was in February. Waiting for Google at this point: |
@macdonst any update on this? Thanks. Edit: using the latest release fixed it. |
I'm getting lot of errors with google gcm and i know the solutions is to disable bitcode in X-Code.
But i'm getting too many warnings and might end up submitting an app which apple might delay in approving.
Is there any way to disable all this GCM clutter for IOS?
The text was updated successfully, but these errors were encountered: