Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Phoenix.js documentation on hexdocs.pm for 1.6.0 is missing #4519

Closed
askielboe opened this issue Sep 30, 2021 · 6 comments · Fixed by #4543
Closed

Phoenix.js documentation on hexdocs.pm for 1.6.0 is missing #4519

askielboe opened this issue Sep 30, 2021 · 6 comments · Fixed by #4543

Comments

@askielboe
Copy link

Environment

  • Elixir version (elixir -v):
  • Phoenix version (mix deps): 1.6.0
  • Operating system: Firefox 92.0 (64-bit)

Expected behavior

Be able to read documentation at https://hexdocs.pm/phoenix/js/index.html

Actual behavior

image

Previous versions work fine, e.g. https://hexdocs.pm/phoenix/1.5.12/js/

@leodag
Copy link
Contributor

leodag commented Oct 11, 2021

This is broken since commit a5d2590. documentation is being run with js/index.js as argument, which doesn't exist.

Maybe it would be worth suggesting to documentation.js to fail when you pass it non-existent files? Seems strange for it to run fine in that scenario.

@leodag
Copy link
Contributor

leodag commented Oct 11, 2021

@mcrumm not sure if this should be closed yet, since the hex.pm docs are still broken until next version. Also, could we do something about the js documentation for 1.6.0~1.6.2 (including rc.0 and rc.1), so they don't stay broken? Would be nice if it could be fixed.

@mcrumm
Copy link
Member

mcrumm commented Oct 11, 2021

Ah, it was closed automatically with the PR commit :) I will re-open, but I do not have access to publish the docs at the moment. // @chrismccord

@mcrumm mcrumm reopened this Oct 11, 2021
@leodag
Copy link
Contributor

leodag commented Oct 11, 2021

Whoops, probably my fault because of the PR message then. Thanks!

@icecapp
Copy link

icecapp commented Oct 19, 2021

still missing

@Gazler
Copy link
Member

Gazler commented Oct 21, 2021

I've published the docs for v1.6.2 (and other v1.6 releases) now.

@Gazler Gazler closed this as completed Oct 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants