From 92e7960b6c59a30f0fe2767f3b225625a89d4bb7 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Anderson=20Val=C3=A9rio?= Date: Fri, 27 Dec 2024 10:10:38 -0300 Subject: [PATCH] fix lint bodyclose --- oauthproxy.go | 16 +++++++++++----- 1 file changed, 11 insertions(+), 5 deletions(-) diff --git a/oauthproxy.go b/oauthproxy.go index 46f5b528f6..88fcdfb03c 100644 --- a/oauthproxy.go +++ b/oauthproxy.go @@ -805,6 +805,12 @@ func (p *OAuthProxy) backendLogout(rw http.ResponseWriter, req *http.Request, si } resp, err = PicsSignOutAllSessions(providerData.BackendLogoutAllSessionsURL, session.IntrospectClaims, session.AccessToken) + if err != nil { + logger.Errorf("error while calling backend logout all sessions: %v", err) + return + } + + defer resp.Body.Close() } else { if providerData.BackendLogoutURL == "" { return @@ -814,14 +820,14 @@ func (p *OAuthProxy) backendLogout(rw http.ResponseWriter, req *http.Request, si // security exception because URL is dynamic ({id_token} replacement) but // base is not end-user provided but comes from configuration somewhat secure resp, err = http.Get(backendLogoutURL) // #nosec G107 - } + if err != nil { + logger.Errorf("error while calling backend logout: %v", err) + return + } - if err != nil { - logger.Errorf("error while calling backend logout: %v", err) - return + defer resp.Body.Close() } - defer resp.Body.Close() if resp.StatusCode != 200 { logger.Errorf("error while calling backend logout url, returned error code %v", resp.StatusCode) }