Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve formatting of A11y View. #1510

Open
pixelzoom opened this issue Oct 29, 2024 · 3 comments
Open

Improve formatting of A11y View. #1510

pixelzoom opened this issue Oct 29, 2024 · 3 comments

Comments

@pixelzoom
Copy link
Contributor

pixelzoom commented Oct 29, 2024

In phetsims/models-of-the-hydrogen-atom#67 (comment), @DianaTavares mentioned a number of presentation improvements that would make things clearer in A11y View.

For example, this part of the A11y View shows 4 different UI components in the Spectra screen -- from top-to-bottom, a NumberControl, CheckBox, non-modal Dialog, and ABSwitch.

screenshot_3564

The lack of spacing and organization in the above layout makes it difficult to parse -- especially since spacing seems to be within UI components, and there is no spacing between UI components. In this screenshot, I've drawn red boxes around the 4 UI components to demonstrate:

screenshot_3565

I discussed this with @jessegreenberg. He said that A11y View is currently primitive, just displays the PDOM, and that there's very little massaging of the visual layout. It's unclear how much work on A11y View should be done, what would benefit designers & developers, etc. But worth a discussion.

@pixelzoom
Copy link
Contributor Author

@jessegreenberg I've assigned this to you, but feel free to unassign if you don't think it's in scope for the current "description refinement" work.

@jessegreenberg
Copy link
Contributor

jessegreenberg commented Nov 8, 2024

Another improvement would be to display other aria attributes. We currently only show aria-valuetext and aria-expanded.

For example, in phetsims/models-of-the-hydrogen-atom#76, it would be nice to see aria-pressed, and possibly role.

@jessegreenberg
Copy link
Contributor

We discussed this during a planning meeting today. We are marking it as "priority 2". We think the changes with the most value are things that would make it easier to understand the structure of the PDOM as a development tool. When we work on this, think about improvements with that in mind.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants