Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(typescript 🐛): don't try to be smarter than tsc #754

Merged
merged 1 commit into from
Jun 16, 2021

Conversation

phenomnomnominal
Copy link
Owner

No description provided.

@phenomnomnominal phenomnomnominal merged commit a928586 into master Jun 16, 2021
@phenomnomnominal phenomnomnominal deleted the let-incremental-be-incremental branch June 16, 2021 09:29
Comment on lines +111 to +114
if (!config.compilerOptions.incremental) {
config.files = filePaths;
delete config.include;
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From my tests last night, a single-file compile with or without incremental set is still significantly faster than incremental even if no files have changed. I'm just filtering out that weird error and calling it good 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants