Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Betterer in CI: Fail command if diff is found #232

Closed
koggdal opened this issue Aug 20, 2020 · 3 comments · Fixed by #543
Closed

Betterer in CI: Fail command if diff is found #232

koggdal opened this issue Aug 20, 2020 · 3 comments · Fixed by #543
Milestone

Comments

@koggdal
Copy link

koggdal commented Aug 20, 2020

Our situation is that we run Betterer in a pre-commit hook, which then commits the changes to the results file. We also run it in CI. However, if someone skips the pre-commit hooks, it will still run fine in CI, but when the change is merged, running Betterer will generate a diff on master.

Could we get a flag to pass to Betterer to skip writing to file, and fail the command if a diff is found?

Thanks! 🙏

@jLouzado
Copy link

jLouzado commented Feb 2, 2021

Maybe a Github Action instead that detects whether there's a new diff on master and makes a commit? The repo is anyway guarded against a regression, this would just be a convenient thing for everyone.

@phenomnomnominal
Copy link
Owner

I've got an implementation of this coming ASAP 😄

@phenomnomnominal phenomnomnominal added this to the V4 milestone Feb 17, 2021
@phenomnomnominal
Copy link
Owner

Should be covered by #250! WIll close when I release V4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants