Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Promote pgr_dijkstraNear and pgr_dijkstraNearCost to proposed #2203

Closed
TimMcCauley opened this issue Oct 27, 2021 · 9 comments
Closed

Promote pgr_dijkstraNear and pgr_dijkstraNearCost to proposed #2203

TimMcCauley opened this issue Oct 27, 2021 · 9 comments

Comments

@TimMcCauley
Copy link

We have been using pgr_dijkstraNear for a clients project heavily over the last few months. With this functionality being in development phase, we can ascertain that it is running stable. By the way, in other services this functionality is often referred to as something around the term "matrix". Maybe the naming could be improved (especially for SEO reasons) as I believe that this will be used by many other pgRouting enthusiasts.

@dkastl dkastl added Discussion Question This is a question labels Oct 27, 2021
@dkastl
Copy link
Member

dkastl commented Oct 27, 2021

Thanks for the feedback!
Maybe we should have something to collect "votes" of users to move "experimental" functions to "stable" after a certain number of confirmations ;-)

Regarding the name, would you say "matrix" suits better? I would expect probably something different with "matrix", but I don't have a suggestion either.

@TimMcCauley
Copy link
Author

Thinking about it again, you are probably right Daniel. As this function returns the shape, the matrix alone doesn't make too much sense, maybe something like pgr_dijkstraMatrixRoutes ?

@cvvergara
Copy link
Member

@TimMcCauley Can you point out where the "matrix" name comes from? I normally associate a matrix with this kind of matrix

@cvvergara
Copy link
Member

I can find this term:
https://www.google.com/search?channel=fs&client=ubuntu&q=graph++neaerst+neighbor
But for graphs, only I can find matrix as representation of a graph
https://www.google.com/search?channel=fs&client=ubuntu&q=graph++matrix

@cvvergara
Copy link
Member

cvvergara commented Oct 27, 2021

Wondering how could one explain with the term "matrix" this example
https://docs.pgrouting.org/latest/en/pgr_dijkstraNear.html#combinations

@TimMcCauley
Copy link
Author

@cvvergara the one-to-many / many-to-many / many-to-one has a "matrix-like" structure in the input params but as I already mentioned, it doesn't make much sense, as it returns more detail than a common matrix computation would yield such as pgr_dijkstraCostMatrix

pgr_dijkstraNear(Edges SQL, Start vid, End vids [, directed] [, cap])
pgr_dijkstraNear(Edges SQL, Start vids, End vid [, directed] [, cap])
pgr_dijkstraNear(Edges SQL, Start vids, End vids [, directed] [, cap], [global])

@cvvergara
Copy link
Member

This is the Cost version of Dijkstra Near :-)
https://docs.pgrouting.org/latest/en/pgr_dijkstraNearCost.html

@cvvergara
Copy link
Member

So we keep the name :-)
Will label it for enhancement

@cvvergara cvvergara added this to the Release 3.3.0 milestone Oct 28, 2021
@cvvergara cvvergara added Enhancement and removed Discussion Question This is a question labels Oct 28, 2021
@TimMcCauley
Copy link
Author

Yes agreed, one name that may work is dijkstraPairs but let's come back to that later :-)

@cvvergara cvvergara self-assigned this Nov 8, 2021
@cvvergara cvvergara changed the title One-to-many / many-to-many / many-to-one with pgr_dijkstraNear Promote pgr_dijkstraNear and pgr_dijkstraNearCost to proposed Nov 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants