Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cancellation tests are failing with --browser option for 3.0.0 #541

Closed
Artazor opened this issue Mar 23, 2015 · 3 comments
Closed

Cancellation tests are failing with --browser option for 3.0.0 #541

Artazor opened this issue Mar 23, 2015 · 3 comments

Comments

@Artazor
Copy link
Contributor

Artazor commented Mar 23, 2015

$ node tools/test --run=cancel.js --browser

failing in browser as there is no Promise.config({cancellation:true}), and I don't see any appropriate place where to put it.

@petkaantonov
Copy link
Owner

Cancellation is still under construction in 3.0, browser tests will be fixed when it's done

@Artazor
Copy link
Contributor Author

Artazor commented Mar 23, 2015

Are you planning to change any significant part of its api? Seems that all cancellation tests are passing now and they are much more detailed than I've expected. Even if 'forget' semantics is a far future, the current use cases (found in tests) looks way better than what we have now. I'd like to develop a d.ts for the 3.0.0 and update a DefinetelyTyped/Bluebird repository that is now seriously outdated.

@petkaantonov
Copy link
Owner

No the api won't change but what remains to be done is interop testing with timers, Promise.join, Promise.using and Promise.coroutine. These features probably don't work with cancellation at all in 3.0 because I haven't implemented interop yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants