Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update github to 1.0.4 + minor bug #1

Open
duzda opened this issue Aug 18, 2021 · 0 comments
Open

Update github to 1.0.4 + minor bug #1

duzda opened this issue Aug 18, 2021 · 0 comments

Comments

@duzda
Copy link

duzda commented Aug 18, 2021

Hello!

Can you please update the github code, which is currently at 1.0.3 to 1.0.4 which is actually used at haxelib?

Also get_rbgHex() is wrong, instead of:
return StringTools.hex(red, 2) + StringTools.hex(green, 2) + StringTools.hex(blue, 2);

It should be:
return StringTools.hex(blue, 2) + StringTools.hex(green, 2) + StringTools.hex(red, 2);

Feel free to see for yourself,

var color = new Color(16711680); // red color #ff0000
Console.log(color.rgbHex);
// Returns #0000ff instead of #ff0000 
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant