Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

putFileContents does not pass onUploadProgress to axios #249

Closed
tmpfs opened this issue Mar 16, 2021 · 4 comments · Fixed by #263
Closed

putFileContents does not pass onUploadProgress to axios #249

tmpfs opened this issue Mar 16, 2021 · 4 comments · Fixed by #263

Comments

@tmpfs
Copy link
Contributor

tmpfs commented Mar 16, 2021

Just spent a lot of time debugging why my progress handler was not firing and finally figured out that putFileContents is not passing onUploadProgress to axios.

I am not sure what the correct fix for this is but happy to submit a quick fix (directly assign to requestOptions) it you would take the PR.

My guess is the bug is in prepareRequestOptions().

@nilskretschmer
Copy link

nilskretschmer commented Mar 26, 2021

Looks good to me. I would need this fix, too - so I hope the commit will be approved 👍

@nilskretschmer
Copy link

Hi,
is there any update on this topic? Can we do something to help?

Greetings!

@perry-mitchell
Copy link
Owner

@NKnuelle This PR was left in the middle of a review and I haven't had time to look into it myself: #250

It could be tidied up or re-made and that'd help, of course.. I will eventually get time to do that myself but I'd appreciate someone else doing that as well of course 🙏

@n-peugnet
Copy link
Contributor

@perry-mitchell I just rebased and cleaned #250 to only keep essential changes in this new pull request: #263

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants