Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Git URL pointing to arbitrary path in the repo #307

Closed
dandv opened this issue Nov 29, 2014 · 12 comments
Closed

Git URL pointing to arbitrary path in the repo #307

dandv opened this issue Nov 29, 2014 · 12 comments
Assignees
Milestone

Comments

@dandv
Copy link

dandv commented Nov 29, 2014

Is this possible? For direct packages, it would be great if the Atmosphere README was picked up from an arbitrary path, rather than the one in the root of the repo.

For instance, git: 'https://github.com/dandv/Font-Awesome/tree/meteor-integration-5.0.0/meteor' would show that Meteor-specific README when going to https://atmospherejs.com/fortawesome/fontawesome.

@tmeasday
Copy link
Member

tmeasday commented Dec 1, 2014

There is an undocumented readme field in package.js that should point to a raw markdown file (like https://raw.githubusercontent.com/percolatestudio/atmosphere/master/README.md).

Does that help?

@dandv
Copy link
Author

dandv commented Dec 11, 2014

@dandv
Copy link
Author

dandv commented Dec 11, 2014

meteor admin change-homepage twbs:bootstrap https://github.com/MeteorPackaging/bootstrap/tree/meteor-integration/meteor didn't change the README either.

@tmeasday
Copy link
Member

Did you publish a new version of the package @dandv ?

@dandv
Copy link
Author

dandv commented Dec 11, 2014

Yep. Just published _2 again to make sure.

@tmeasday
Copy link
Member

Hmm. I'm not seeing it:

{
        "packageName" : "twbs:bootstrap",
        "publishedBy" : {
            "username" : "dandv",
            "id" : "gwRKuoewrwi8MMbMB"
        },
        "version" : "3.3.1_2",
        "earliestCompatibleVersion" : "3.0.0",
        "containsPlugins" : false,
        "debugOnly" : false,
        "description" : "Bootstrap (official): the most popular HTML/CSS/JS framework for responsive, mobile first projects",
        "dependencies" : {
            "meteor" : {
                "constraint" : null,
                "references" : [
                    {
                        "arch" : "os"
                    },
                    {
                        "arch" : "web.browser"
                    },
                    {
                        "arch" : "web.cordova"
                    }
                ]
            },
            "jquery" : {
                "constraint" : "1.0.0",
                "references" : [
                    {
                        "arch" : "os"
                    },
                    {
                        "arch" : "web.browser"
                    },
                    {
                        "arch" : "web.cordova"
                    }
                ]
            }
        },
        "git" : "https://github.com/MeteorPackaging/bootstrap.git",
        "releaseName" : null,
        "compilerVersion" : "meteor/14",
        "ecRecordFormat" : "1.1",
        "source" : {
            "url" : "https://warehouse.meteor.com/sources/gwRKuoewrwi8MMbMB/1418339140070/znnPhcnJhH/twbs:bootstrap-3.3.1_2-source.tgz",
            "tarballHash" : "uwGTTpYSKGENs4pM65jsueKs6joRIOyKFroazh4aHr0=",
            "treeHash" : "ZFvf7g9e9yVZA7Ec7EBfFVDgQ8omUIDebFj96ypD9RY="
        },
        "lastUpdated" : ISODate("2014-12-11T23:05:40.609Z"),
        "published" : ISODate("2014-12-11T23:05:40.609Z"),
        "_id" : "Yfo9eSCHBp3kKpjay"
    }

I wonder if there's some special way you have to do it (only MDG have done it before). Will investigate.

@tmeasday
Copy link
Member

@dandv
Copy link
Author

dandv commented Dec 12, 2014

Interesting... @estark37, how did you guys do that?

@zol
Copy link
Member

zol commented Feb 3, 2015

@tmeasday Could you please follow up on this one.

@zol zol modified the milestone: Next Up Feb 3, 2015
@ekatek
Copy link

ekatek commented Feb 3, 2015

That wasn't actually a custom GIT path, but a custom README path. This has been deprecated in favor of the 1.0.3.1 changes that upload the README.md directly!

@tmeasday
Copy link
Member

tmeasday commented Feb 3, 2015

I guess we can close this right? Thanks @ekatek. @dandv let me know if there's a problem.

@tmeasday tmeasday closed this as completed Feb 3, 2015
@dandv
Copy link
Author

dandv commented Feb 3, 2015

I've tried the README option and it works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants