Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the check-licenses script #137

Closed
pento opened this issue Mar 31, 2019 · 0 comments · Fixed by #155
Closed

Use the check-licenses script #137

pento opened this issue Mar 31, 2019 · 0 comments · Fixed by #155
Assignees
Labels
[Type] Enhancement New feature or request
Milestone

Comments

@pento
Copy link
Owner

pento commented Mar 31, 2019

We should automatically check licenses on PRs.

Running check-licenses on the repo finds a couple of issues:

$ npx wp-scripts check-licenses --dev
 ERROR  Module xmldom has an incompatible license 'LGPL'.
$ npx wp-scripts check-licenses --prod --gpl2
 ERROR  Module detect-libc has an incompatible license 'Apache-2.0'.

xmldom is an easy fix, we just need to add LGPL to @wordpress/wp-scripts.

detect-libc is a little trickier, as it's ultimately included by chokidar, which we do use. nsfw is an interesting alternative to chokidar, it's also used by VS Code.

@pento pento added the [Type] Enhancement New feature or request label Mar 31, 2019
@pento pento added this to the 1.0 milestone Mar 31, 2019
@pento pento self-assigned this Apr 1, 2019
This was referenced Jun 5, 2019
@pento pento closed this as completed in #155 Jun 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant