Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add missing type exports #959

Merged
merged 1 commit into from
May 24, 2022
Merged

Conversation

jwetzell
Copy link
Contributor

With a fresh angular project created using ng new peerjs-test and the installing the peerjs library npm install --save peerjs trying to import the library via import {Peer} from 'peerjs' results in the following error.

Error: ../peerjs/dist/types.d.ts:49:1 - error TS1046: Top-level declarations in .d.ts files must start with either a 'declare' or 'export' modifier.

49 enum LogLevel {

adding the missing types to the exports.ts causes them to be exported in the resulting types.d.ts file which resolves this build issue.

@Praveenjana20
Copy link

fix for #961

@jonasgloning jonasgloning merged commit 3c915d5 into peers:master May 24, 2022
github-actions bot pushed a commit that referenced this pull request May 24, 2022
## [1.4.5](v1.4.4...v1.4.5) (2022-05-24)

### Bug Fixes

* **referrerPolicy:** you can now set a custom referrerPolicy for api requests ([c0ba9e4](c0ba9e4)), closes [#955](#955)
* **typings:** add missing type exports ([#959](#959)) ([3c915d5](3c915d5)), closes [#961](#961)
@github-actions
Copy link

🎉 This PR is included in version 1.4.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

@jonasgloning
Copy link
Member

Thank you both very much! Especially for the PR.

@jwetzell
Copy link
Contributor Author

No problem! Glad I could contribute, and thanks for the quick review and merge!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

type.d.ts error TS1046- Unable to use Peerjs NPM package in the latest angular version.
3 participants