Skip to content

Commit bb69197

Browse files
mshibuyapcai
authored andcommitted
Fix filter box being duplicated on browser back
Fixes railsadminteam#3570
1 parent 8427137 commit bb69197

File tree

2 files changed

+14
-1
lines changed

2 files changed

+14
-1
lines changed

spec/integration/widgets/filter_box_spec.rb

+13
Original file line numberDiff line numberDiff line change
@@ -86,6 +86,19 @@
8686
end
8787
end
8888

89+
it 'does not cause duplication when using browser back' do
90+
RailsAdmin.config Player do
91+
field :name
92+
end
93+
94+
visit index_path(model_name: 'player', f: {name: {'1' => {v: 'a'}}})
95+
find(%([href$="/admin/player/export"])).click
96+
is_expected.to have_content 'Export Players'
97+
page.go_back
98+
is_expected.to have_content 'List of Players'
99+
expect(all(:css, '#filters_box div.filter').count).to eq 1
100+
end
101+
89102
describe 'for boolean field' do
90103
before do
91104
RailsAdmin.config FieldTest do

src/rails_admin/filter-box.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -172,7 +172,7 @@ import flatpickr from "flatpickr";
172172
}
173173

174174
var filterContainerId = field_name + "-" + index + "-filter-container";
175-
$("p#" + filterContainerId).remove();
175+
$("#" + filterContainerId).remove();
176176

177177
var $content = $("<div>")
178178
.attr("id", filterContainerId)

0 commit comments

Comments
 (0)