Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

End times inconsistent on event feed for "judgements" #962

Closed
johnbrvc opened this issue May 9, 2024 · 1 comment
Closed

End times inconsistent on event feed for "judgements" #962

johnbrvc opened this issue May 9, 2024 · 1 comment
Labels
bug Something isn't working Primary CCS Required for PC2 to act as primary CCS Shadow Bugs relating to Shadow Contest Feature

Comments

@johnbrvc
Copy link
Collaborator

johnbrvc commented May 9, 2024

Describe the issue:
For "judgements" type events, the data object contains several time properties: start_time, start_contest_time, end_time, end_contest_time. It seems the end_time and the end_contest_time can be less than the corresponding start_time and start_contest_time:

{"type":"judgements", "id":"pc2-1975", "op":"create", "data": {"id":"Run--4136172624303351484","submission_id":"6",
    "start_time":"2023-10-29T11:20:49.029-04","start_contest_time":"00:05:49.094","judgement_type_id":"AC",
    "end_time":"2023-10-29T11:20:00-04","end_contest_time":"00:05:00.000"}}

To Reproduce:

  1. Start a completed contest (one with submissions and judgments)
  2. Start an event feeder server
  3. Using curl, read the event feed to a file: curl -k https://admin:admin@localhost:50443/contest/event-feed >ef.json
  4. Edit the produced ef.json and search for "judgements" events.
  5. Note the end times. (see example above) They are less than the corresponding start times.

Expected behavior:
The end times should be greater than or equal to the corresponding start times.

Actual behavior:
The end times are less than the start times. (rounded down to the previous minute).

Environment:
All.

Log Info:

Screenshots:

Additional context:
It looks like PC2 uses the floor of the contest minute as the end time for judgments, it probably shouldn't do this.

@johnbrvc johnbrvc added bug Something isn't working Shadow Bugs relating to Shadow Contest Feature Primary CCS Required for PC2 to act as primary CCS labels May 9, 2024
@johnbrvc
Copy link
Collaborator Author

johnbrvc commented Jun 3, 2024

Duplicate of #712

@johnbrvc johnbrvc marked this as a duplicate of #712 Jun 3, 2024
@johnbrvc johnbrvc closed this as completed Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Primary CCS Required for PC2 to act as primary CCS Shadow Bugs relating to Shadow Contest Feature
Projects
None yet
Development

No branches or pull requests

1 participant