Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SubmitClarification class should be reverted. #1039

Open
clevengr opened this issue Jan 30, 2025 · 0 comments · May be fixed by #1041
Open

SubmitClarification class should be reverted. #1039

clevengr opened this issue Jan 30, 2025 · 0 comments · May be fixed by #1041
Assignees

Comments

@clevengr
Copy link
Contributor

clevengr commented Jan 30, 2025

Work on branch "i1030_WTI_Clar_Announcement_Filtering" in the clevengr/fork results in creating a new class, GenerateAnnouncement. This class extracts (with author attribution) work done on the SubmitClarification class to support sending "announcements", and extends that work to support sending announcements simultaneously to multiple groups AND multiple teams. The branch also removes the Submit Clarification tab from the JudgeView screen, replacing it with a new Generate Announcement tab.

In order to retain the SubmitClarification functionality (in the event that it might be needed in the future), the work on the above branch includes adding Submit Clarification to the "Developer Pane". However, the implementation of SubmitClarification on the DeveloperPane still retains the added "announcement" functionality, and when it is executed in the Developer Pane it throws an exception.

Since SubmitClarification no longer needs to provide separate support for announcements (because that functionality is migrated to new class GenerateAnnouncement), the code in SubmitClarification should be reverted to its "pre-announcement" state. This may also eliminate the exception it currently throws.

Note: all of this is contingent on merging a PR from the "i1030_WTI_CLar_Announcement_Filtering" clevengr/fork. Until that happens, this issue should be dormant.

@clevengr clevengr self-assigned this Feb 1, 2025
@clevengr clevengr linked a pull request Feb 6, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant