You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Work on branch "i1030_WTI_Clar_Announcement_Filtering" in the clevengr/fork results in creating a new class, GenerateAnnouncement. This class extracts (with author attribution) work done on the SubmitClarification class to support sending "announcements", and extends that work to support sending announcements simultaneously to multiple groups AND multiple teams. The branch also removes the Submit Clarification tab from the JudgeView screen, replacing it with a new Generate Announcement tab.
In order to retain the SubmitClarification functionality (in the event that it might be needed in the future), the work on the above branch includes adding Submit Clarification to the "Developer Pane". However, the implementation of SubmitClarification on the DeveloperPane still retains the added "announcement" functionality, and when it is executed in the Developer Pane it throws an exception.
Since SubmitClarification no longer needs to provide separate support for announcements (because that functionality is migrated to new class GenerateAnnouncement), the code in SubmitClarification should be reverted to its "pre-announcement" state. This may also eliminate the exception it currently throws.
Note: all of this is contingent on merging a PR from the "i1030_WTI_CLar_Announcement_Filtering" clevengr/fork. Until that happens, this issue should be dormant.
The text was updated successfully, but these errors were encountered:
Work on branch "i1030_WTI_Clar_Announcement_Filtering" in the clevengr/fork results in creating a new class,
GenerateAnnouncement
. This class extracts (with author attribution) work done on theSubmitClarification
class to support sending "announcements", and extends that work to support sending announcements simultaneously to multiple groups AND multiple teams. The branch also removes theSubmit Clarification
tab from theJudgeView
screen, replacing it with a newGenerate Announcement
tab.In order to retain the
SubmitClarification
functionality (in the event that it might be needed in the future), the work on the above branch includes addingSubmit Clarification
to the "Developer Pane". However, the implementation ofSubmitClarification
on the DeveloperPane still retains the added "announcement" functionality, and when it is executed in the Developer Pane it throws an exception.Since SubmitClarification no longer needs to provide separate support for announcements (because that functionality is migrated to new class
GenerateAnnouncement
), the code inSubmitClarification
should be reverted to its "pre-announcement" state. This may also eliminate the exception it currently throws.Note: all of this is contingent on merging a PR from the "i1030_WTI_CLar_Announcement_Filtering" clevengr/fork. Until that happens, this issue should be dormant.
The text was updated successfully, but these errors were encountered: