Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Group (division) scoreboard JSON files use an old format #1017

Open
johnbrvc opened this issue Nov 19, 2024 · 0 comments
Open

Group (division) scoreboard JSON files use an old format #1017

johnbrvc opened this issue Nov 19, 2024 · 0 comments
Labels
bug Something isn't working CLICS CCS Update Changes to update to the CLICS specification NEXT Contest Consider fixing for next contet

Comments

@johnbrvc
Copy link
Collaborator

Describe the issue:
When the scoreboard client generates the scoreboard JSON report for each division (group) the format of the JSON file is wrong. This issue was discovered by the DOMjudge team when trying to compare scoreboards.

To Reproduce:
Run the scoreboard thick client on a contest that uses multiple division (groups).
Look in the "results" folder for one of the generated ".json" files.
Note the format is incorrect:

[
   {
      "problems" : [
         {
            "first_to_solve" : true,
            "label" : "A",
            "num_judged" : 1,
            "num_pending" : 0,
            "solved" : true,
            "time" : 15
         },
         {
            "first_to_solve" : false,
            "label" : "B",
            "num_judged" : 1,
            "num_pending" : 0,
            "solved" : true,
            "time" : 27
         },

The JSON file should have a header, and, each problem should contain a "problem_id" property as in:

{
   "contest_time" : "",
   "event_id" : "48ae19d2-07eb-4123-9b26-cca6851ed330",
   "rows" : [
      {
         "problems" : [
            {
               "num_judged" : 3,
               "num_pending" : 0,
               "problem_id" : "billboards",
               "solved" : true,
               "time" : 158
            },
            {
               "num_judged" : 1,
               "num_pending" : 0,
               "problem_id" : "bingoforthewin",
               "solved" : true,
               "time" : 26
            },

Expected behavior:
A CLICS style scoreboard JSON file should be produced.

Actual behavior:
A "2016" style scoreboard is produced (older specification).

Environment:
All

Log Info:

Screenshots:

Additional context:
The older StandingsJSON2016 is being used when generating scoreboard JSON reports for groups instead of the newer CLICSScoreboard.

@johnbrvc johnbrvc added bug Something isn't working CLICS CCS Update Changes to update to the CLICS specification NEXT Contest Consider fixing for next contet labels Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working CLICS CCS Update Changes to update to the CLICS specification NEXT Contest Consider fixing for next contet
Projects
None yet
Development

No branches or pull requests

1 participant