Submissions can be ignored on the shadow feed if source zip has 0 length file. #1014
Labels
bug
Something isn't working
high priority
Bugs that are high priority (to fix)
NEXT Contest
Consider fixing for next contet
Shadow
Bugs relating to Shadow Contest Feature
Describe the issue:
In the event feeder client shadow mode, if the zip file containing the user source code (and auxiliary files) contains a zero length file, the submission is ignored and an error is generated.
To Reproduce:
Expected behavior:
The submission should not be ignored and no error should occur if a source zip contains a zero length file.
Actual behavior:
As described above, the submission is tossed and an error generated.
Environment:
All.
Log Info:
Screenshots:
Additional context:
The issue is related to the fact that PC2 reads the zip as a stream. If there is a zero length file in the zip, this fails. The exact issue is described here: OpenJDK Bug Report
The solution is to save the stream to a file first, the use ZipFile to extract it.
There is a fix for this in this branch: JohnB's branch for combined scoreboards and this commit. It will be integrated in the main develop branch after regionals. Affected file:
ecs/pc2/shadow/RemoteContestAPIAdapter.java
The text was updated successfully, but these errors were encountered: