-
Notifications
You must be signed in to change notification settings - Fork 218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VNA measurement doesn't deliver any plausible values, Official Red Pitaya OS VNA although does #1154
Comments
Thank you for testing the VNA application and for finding this problem. I cannot think of any better approach to understanding this problem than to compare the source codes of the two versions of the VNA application. According to the commit number in This code looks mostly similar to the code from the 20220322 release of this repository. Could you please check if this release works for you? |
Thank you for testing the 20220322 release. It looks like I introduced a bug into the VNA project in some changes that I made in 2023. I see a couple of suspicious changes in this commit. I think that I now need to build a test setup to reproduce this problem and identify the exact change responsible for this problem. |
I found the source of the problem and fixed it with this commit. |
Awesome, that is great news! While trying it out, I noticed that I made your 2022 version slower by modifying it (I had removed the ADC2 channel and its related functionality), Your current version is twice as fast, so I’ll definitely revert my changes and stick with your updated version. Thank you once again for your great work! Best regards, |
Thank you for testing this fix. The fixed version is now in the new release. |
Description of the setup:
Device:
Red Pitaya Stemlab 125-14 V1.0
SD card image:
Application:
VNA
Latest vna.py client
Other relevant information:
Description of the problem:
I'm not able to reproduce the same VNA Measurements, when using the VNA app on your images, as opposed to the
VNA on the official RedPitaya_OS (2.04)
Steps to reproduce the problem:
Dear Pavel,
For a university project, where we tune and match Antennas, I'm trying to use your VNA Project on the Red Pitaya, but I'm not able to see any plausible measurements on the VNA of the Alpine Image, I've tried the official VNA Adapter for the Red Pitaya as well as Mini-Circuits Couplers.
How it should look like (using the Offical RedPitaya OS)
![WorkingVNA](https://private-user-images.githubusercontent.com/163022404/376054900-ad341c9e-0a34-494a-b079-4ca388a41cab.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkzMzQyMzgsIm5iZiI6MTczOTMzMzkzOCwicGF0aCI6Ii8xNjMwMjI0MDQvMzc2MDU0OTAwLWFkMzQxYzllLTBhMzQtNDk0YS1iMDc5LTRjYTM4OGE0MWNhYi5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMjEyJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDIxMlQwNDE4NThaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT04Y2M0OTBmM2U1ZjZiMjNhYmQxMmYwOTc3NDgzNGM5ZDk1ODAxYzQ2OWZhNTA2OTE5YmM1ZTE2OGQwYzc3MTdhJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.VbXhGGTVNuxY-Om5hiM7S4fTuaUyFT6o7mmgBpk5oOM)
How the SWR on the VNA of the Alpine Images looks like:
![SWR_NOTWORKING](https://private-user-images.githubusercontent.com/163022404/376054933-d506264c-6238-4674-bf53-059f74f99886.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkzMzQyMzgsIm5iZiI6MTczOTMzMzkzOCwicGF0aCI6Ii8xNjMwMjI0MDQvMzc2MDU0OTMzLWQ1MDYyNjRjLTYyMzgtNDY3NC1iZjUzLTA1OWY3NGY5OTg4Ni5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMjEyJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDIxMlQwNDE4NThaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT04NmEwNWU1YzEyNDZmMTEzY2VjNjI5MDM0YWMzNzc5NjFhNWQ2ZmQ2N2YzMjYzN2NiOGVkMWE1NTkyMzA3YTM2JlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.xVHB5U_f7tnjL4eYrUN7BEBmPye56KAo9aOeRRpVAio)
Calibration steps of the "not working VNA" :
![load_notworking](https://private-user-images.githubusercontent.com/163022404/376055333-ac783c74-1593-44d2-900e-492be75269eb.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkzMzQyMzgsIm5iZiI6MTczOTMzMzkzOCwicGF0aCI6Ii8xNjMwMjI0MDQvMzc2MDU1MzMzLWFjNzgzYzc0LTE1OTMtNDRkMi05MDBlLTQ5MmJlNzUyNjllYi5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMjEyJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDIxMlQwNDE4NThaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT0xNTBiMjE4OWM1OTI4MzQ2Zjg5NDcxZDk2Njk5Y2FiNmMzNmFlZTJmZWRkMjhlZGM4NDc5Yjc4MGQxZWM4NmZkJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.3Vfd49SmYl36trXbyrHgdjMyfLZBBqrJc__gxxLqo38)
![OPEN_notworking](https://private-user-images.githubusercontent.com/163022404/376055338-2bc3fa0f-fb1d-4ba1-a406-5c93d7411901.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkzMzQyMzgsIm5iZiI6MTczOTMzMzkzOCwicGF0aCI6Ii8xNjMwMjI0MDQvMzc2MDU1MzM4LTJiYzNmYTBmLWZiMWQtNGJhMS1hNDA2LTVjOTNkNzQxMTkwMS5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMjEyJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDIxMlQwNDE4NThaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT03MmE3NzhhNjVmYzFmMjE0MTFjMDM5MDJiZThkNTYxZmFkNTg0NTVjNDYxOTA0MjBlMTMzZWE5NWQ1MmE5OTkxJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.gpOXdGoxmtovE1D_Xs8IJV37v9r1Ki1d03uRwEfRL-4)
![Short_notworking](https://private-user-images.githubusercontent.com/163022404/376055340-7c7edebf-a625-4ac4-a557-186eee91e572.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkzMzQyMzgsIm5iZiI6MTczOTMzMzkzOCwicGF0aCI6Ii8xNjMwMjI0MDQvMzc2MDU1MzQwLTdjN2VkZWJmLWE2MjUtNGFjNC1hNTU3LTE4NmVlZTkxZTU3Mi5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMjEyJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDIxMlQwNDE4NThaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT01ZjIxOWNmNDg3MzI2NjViYzk3MTllNjVlYTQyNjVhZTU2ODI1NmJkMzk2NTliNzliZjdjZTk2NWMzMzM3OTA4JlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.fj1HBz0Xbu35NWPvV3Eln0E7X_4v1ZC5bG1pZAEgBaU)
LOAD:
OPEN:
SHORT:
I understand that the issue is probably on my side, since the VNA of the Red Pitaya OS is basically your VNA, but since the Red Pitaya restarts when using your vna.c file on it, the red pitaya crashes, so they must have changed something.
I've discovered the issue by trying to generate the .bit file of the VNA myself and converting and transferring it to the red pitaya.
I've wrapped the block_design.tcl myself in vivado (using your make file, which lead to an error explaining that vna.gen couldn't be found, but it built the whole project, so i was able to wrap it myself) and added the constraints from your other projects (clock.xdc and ports.xdc).
I originally thought i made some mistakes here, but I've found your alpine images, where i could rule out, that i was using wrong files.
I've also tried older Red Pitaya Images and I've also revalidated the SWR (how it should look like) with the minivna-tiny and at the university with an Rohde&Schwarz VNA, so the DUT is not the issue either.
I have looked through all the issues on github on your account and on the redpitaya account and haven't found something regarding this topic either, except that it seems to work for other people.
So I kindly ask for your help on this topic, since I've not been able to fix it myself, and I'm stuck for a while now.
Maybe you can provide other things i can try out, why it seems to not work for me.
I will try out another redpitaya, if there is one available, again as well, but since the VNA on the RedPitayaOS seems to work, it doesn't seem to me like an RP issue.
I also wanna take the opportunity and thank you, for providing all this open source material surrounding FPGAs.
Best regards,
David
The text was updated successfully, but these errors were encountered: