Skip to content
This repository has been archived by the owner on Feb 5, 2025. It is now read-only.

Vertical navigation is not keyboard accessible #723

Closed
rhamilto opened this issue Aug 25, 2017 · 8 comments
Closed

Vertical navigation is not keyboard accessible #723

rhamilto opened this issue Aug 25, 2017 · 8 comments
Labels

Comments

@rhamilto
Copy link
Member

rhamilto commented Aug 25, 2017

Vertical navigation is not keyboard accessible. The addition of href attributes to the <a> in the test pages will partially resolve this issue. However, secondary and tertiary nav menus will remain inaccessible to keyboard navigation at desktop resolutions without additional changes.

In adopting PatternFly's vertical nav in OpenShift, this issue results in a regression from our current nav which is fully keyboard accessible.

cc: @spadgett, @ncameronbritt, @serenamarie125, @jeff-phillips-18

@LHinson
Copy link
Member

LHinson commented Aug 29, 2017

Thanks @rhamilto. @matthewcarleton has a story to address the href attributes first. See: https://patternfly.atlassian.net/browse/PTNFLY-2533

We will look at the secondary and tertiary after the above is complete.

@LHinson
Copy link
Member

LHinson commented Sep 15, 2017

@jgiardino will be picking up this story to add further enhancements related to the secondary and tertiary menus. https://patternfly.atlassian.net/browse/PTNFLY-2537

FYI @rhamilto

@andresgalante
Copy link
Member

@LHinson the CSS part of PR #766 is ready to merge, we need to include the Javascript for it.

@LHinson
Copy link
Member

LHinson commented Oct 16, 2017

@andresgalante I see some open questions on the PR. Are you sure it's ready to merge?

@matthewcarleton
Copy link
Contributor

#766 Relates to this and another open issue #839
Should we consider prioritizing it to get it merged @LHinson?
@jgiardino suggested breaking it out to deal with these specific issues so that could be an option as well.

@jgiardino
Copy link
Contributor

I think the css updates in #766 addresses the issues in #839
I'm hesitant to really do anything more in the html other than just making the keyboard accessible.

@LHinson LHinson assigned jgiardino and unassigned matthewcarleton Jul 3, 2018
@jgiardino jgiardino added js and removed css labels Jul 9, 2018
@jgiardino
Copy link
Contributor

This is primarily a design and JS issue. I suggest pairing 🍐 up a designer and JS dev to investigate a solution that's possible in all the JS repos.

I removed the css label since css updates related to keyboard navigation can be included for issue #839.

@LHinson
Copy link
Member

LHinson commented Aug 15, 2019

Closing per a conversation with Robb. Thanks for taking a look at those.

@LHinson LHinson closed this as completed Aug 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

5 participants