Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Application Launcher dropdown implementation should remove arrow #741

Open
lizsurette opened this issue May 24, 2018 · 4 comments
Open

Application Launcher dropdown implementation should remove arrow #741

lizsurette opened this issue May 24, 2018 · 4 comments

Comments

@lizsurette
Copy link

The new design for the application launcher does not include an arrow in the dropdown. See: http://www.patternfly.org/pattern-library/application-framework/masthead/#design

The application launcher design will be updated to reflect this change and the angular code should be updated as well here:
http://www.patternfly.org/angular-patternfly/#/api/patternfly.navigation.component:pfApplicationLauncher

@dtaylor113
Copy link
Member

Hi @lizsurette, are you saying the arrow in the Help dropdown is no longer in the dropdown? Is this a Masthead Issue or an issue for the Application Launcher? -thanks

@lizsurette
Copy link
Author

lizsurette commented May 24, 2018

Hey @dtaylor113 there is a bit of history on where this bug was identified over the in react repo here:
patternfly/patternfly-react#319

The react team is implementing the launcher and it was identified that the arrow (after the user has clicked on the dropdown there is an arrow pointing back up to the icon they clicked on) should no longer be there so we are just trying to remove the arrow where it's already been implemented.

But essentially, the design of the application launcher has changed with the new masthead design. The application launcher design along with the angular implementation needs to be updated to reflect the new masthead design. @mcarrano is adding an issue on the design side.

@lizsurette
Copy link
Author

@dtaylor113 with that being said...I don't think we want that arrow next to the help icon either :) Check this base implementation out of the app launcher:
http://www.patternfly.org/pattern-library/application-framework/launcher/#code

@dtaylor113
Copy link
Member

ah, ok, in the App Launcher popup, no arrow pointing back up to the App Launcher icon in the masthead. -thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants