Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider marking all events read when closing the drawer (behavior discussion) #573

Open
benjaminapetersen opened this issue Aug 15, 2017 · 5 comments

Comments

@benjaminapetersen
Copy link
Member

Per discussion with @beanh66, @spadgett & this web console PR, I'd like to propose at least an attribute on the drawer to mark all notifications read when closing the drawer.

In an especially chatty environment with a lot of events, its helpful to be able to clearly see new events since last view, w/o leaving it to the user to manually maintain this unread list (by clicking "mark all read" every time). Its a common pattern on the web, so I don't think we would be venturing into unexpected territory.

@benjaminapetersen
Copy link
Member Author

@jeff-phillips-18

@jeff-phillips-18
Copy link
Member

Any particular reason this couldn't be done by the application in the onClose callback?

I suppose it could call the onMarkAllRead function for each of the groups but unsure if it is warranted to do here and add yet another flag to the drawer's parameter list.

@benjaminapetersen
Copy link
Member Author

True! That would work fine. We can skip the parameter.

@beanh66 do we need to worry about making this behavior a standard thing in Patternfly? Perhaps that is all we wanted to spin out of the discussion.

@benjaminapetersen benjaminapetersen changed the title Consider marking all events read when closing the drawer Consider marking all events read when closing the drawer (behavior discussion) Aug 15, 2017
@beanh66
Copy link
Member

beanh66 commented Aug 16, 2017

@benjaminapetersen I think it makes sense to do some user testing on the current implementation first and if we determine this will improve the user experience, we can make the change and get it contributed into PatternFly. I'll assign it to myself for now to be sure we get customer feedback.

@beanh66 beanh66 self-assigned this Aug 16, 2017
@spadgett
Copy link
Contributor

The OpenShift use case might be unique because potentially there are a lot of events and thus a lot of notifications. It's probably less of a problem if we're more selective about what events to show.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants