Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Smoothing Methods like Jacobi & Gauss-Seidel #116

Open
Ceyron opened this issue Nov 20, 2024 · 5 comments
Open

Smoothing Methods like Jacobi & Gauss-Seidel #116

Ceyron opened this issue Nov 20, 2024 · 5 comments
Labels
question User queries

Comments

@Ceyron
Copy link
Contributor

Ceyron commented Nov 20, 2024

Hi Patrick & Jason,

Thanks for this wonderful library. I was curious if you are interested in adding smoothing methods based on matrix decomposition, such as the Jacobi method or Gauss-Seidel (potentially with the option for relaxation).

Certainly, these solvers a way less efficient than the Krylov ones and need matrix materialization (the state of sparse matrices in JAX is not mature enough?!?), but they could complete the suite of solvers. They might also serve as a nice educational example.

@vboussange
Copy link

Hey @Ceyron, this relates to #113 and #8 . Those methods would be very useful in multigrid methods that could be used for preconditioners to feed into e.g. GMRES. I am currently running a project that needs those. It could be nice to coordinate; I suggested to implement an example with preconditioning for solving a 2D Poisson system in #8, although I have not advanced on that yet.

@patrick-kidger
Copy link
Owner

I'd be happy to take a PR on these :)

@patrick-kidger patrick-kidger added the question User queries label Nov 20, 2024
@Ceyron
Copy link
Contributor Author

Ceyron commented Nov 21, 2024

I'd be happy to take a PR on these :)

Excellent. Then, we could start working on this in the coming weeks.

@vboussange: Do you already have some code for Jacobi or Gauss-Seidel? Otherwise, I would start looking into subclassing a new iterative solver since I need it for my research anyway.

@vboussange
Copy link

@Ceyron Nope, I have not started digging into that - great that you can take the lead! I had in mind to get inspired from AMG.jl, specifically here and there. Let me know if I can help!

@Ceyron
Copy link
Contributor Author

Ceyron commented Nov 21, 2024

@Ceyron Nope, I have not started digging into that - great that you can take the lead! I had in mind to get inspired from AMG.jl, specifically here and there. Let me know if I can help!

No problem 👍 Cool, then I'd start fresh with Jacobi & GaussSeidel. I want to create a first draft and afterward loop you in for some feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question User queries
Projects
None yet
Development

No branches or pull requests

3 participants