Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build Error: three fails to build #559

Closed
mrdoob opened this issue Aug 27, 2021 · 2 comments
Closed

Build Error: three fails to build #559

mrdoob opened this issue Aug 27, 2021 · 2 comments
Assignees

Comments

@mrdoob
Copy link

mrdoob commented Aug 27, 2021

Package name

https://bundlephobia.com/package/three

Entire (stringified) error that I see in my browser console

"Failed to build this package."

Screen Shot 2021-08-27 at 12 50 46 PM

I suspect it is because we tried using private class fields.

More info: mrdoob/three.js#22437

@dmnsgn
Copy link

dmnsgn commented Aug 27, 2021

I suspect it is because we tried using private class fields.

Highly likely. The gist of it is that bundlephobia compiles your code with Webpack 4 which is using an older version of acorn that cannot parse the newer JavaScript syntaxes (nullish coalescing, optional chaining, top-level await and export ns from...).

In this case, bundlephobia tools will need an upgrade. See: #413 (comment)

@marcofugaro
Copy link

This issue can be closed, it was fixed as mentioned here

@mrdoob mrdoob closed this as completed Dec 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants