Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker image size #108

Closed
TheYkk opened this issue May 29, 2020 · 2 comments
Closed

Docker image size #108

TheYkk opened this issue May 29, 2020 · 2 comments

Comments

@TheYkk
Copy link
Contributor

TheYkk commented May 29, 2020

Compiled password-server doesn't need alpine image to run

To fix this we can remove alpine image and replace with scratch image

- FROM alpine:3.11
+ FROM scratch
@yakuter
Copy link
Collaborator

yakuter commented May 29, 2020

@TheYkk but our docker image first compiles passwall-server. So do we need 2 docker images or can we fix this in one image?

@TheYkk
Copy link
Contributor Author

TheYkk commented May 29, 2020

Yes, we can fix it by changing just one line.
We have 2 layer;
First one build go static binary
Second one copy from the first stage and execute binary and we don't need alpine to execute binary so we can remove alpine image from second stage

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants