Address UI race conditions #229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- IntentsManager: @mainactor, non-shared, continuation - SSIDReader: @mainactor, continuation - Reviewer: main queue, non-shared
There were background thread calls e.g. in VPNToggle, because ProfileManager was used inside a VPNManager async call. Annotate @mainactor wherever a Task involves UI.
keeshux
force-pushed
the
actor-race-conditions
branch
from
785fc78 to
ea164c0
Compare
keeshux
force-pushed
the
actor-race-conditions
branch
from
ea164c0 to
22a676d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the very first attempt at resolving race conditions due to UI updates coming from non-main actor. SwiftUI behavior is not fully transparent when it comes to the new Concurrency framework.
The PR clutters code with countless
@MainActorannotations, but as a start, better be safe than sorry.