Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor duplication for generation of composite fields #328

Closed
ascjones opened this issue Nov 24, 2021 · 0 comments · Fixed by #352
Closed

Refactor duplication for generation of composite fields #328

ascjones opened this issue Nov 24, 2021 · 0 comments · Fixed by #352

Comments

@ascjones
Copy link
Contributor

Extracted from #309.

There is some code duplication between type_def and struct_def for generating composite fields for structs and enum variants. This can be consolidated and would ahve avoided bugs such as #327.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor type generation, remove code duplication paritytech/subxt
1 participant
@ascjones