Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

balances pallet: test locks of zero #14231

Closed
liamaharon opened this issue May 26, 2023 · 0 comments · Fixed by #14284
Closed

balances pallet: test locks of zero #14231

liamaharon opened this issue May 26, 2023 · 0 comments · Fixed by #14284
Labels
I5-tests Tests need fixing, improving or augmenting. Z1-easy Can be fixed primarily by duplicating and adapting code by an intermediate coder Z6-mentor An easy task where a mentor is available. Please indicate in the issue who the mentor could be.

Comments

@liamaharon
Copy link
Contributor

liamaharon commented May 26, 2023 •
edited
Loading

Add a test checking the lock is properly removed when set_lock is called with amount zero
https://github.com/paritytech/substrate/pull/14144/files#diff-0848af5dac3286b1cf09718d38571925e65582729dedacceef836bb2278b612dR857

          someone needs to write some tests for this

Originally posted by @xlc in #14144 (comment)
@liamaharon liamaharon added Z6-mentor An easy task where a mentor is available. Please indicate in the issue who the mentor could be. I5-tests Tests need fixing, improving or augmenting. Z1-easy Can be fixed primarily by duplicating and adapting code by an intermediate coder labels May 26, 2023
@liamaharon liamaharon moved this from Backlog to To Do in Runtime / FRAME May 26, 2023
@jpserrat jpserrat mentioned this issue Jun 1, 2023
Merged
@juangirini juangirini moved this from To Do to In Progress in Runtime / FRAME Jun 2, 2023
@github-project-automation github-project-automation bot moved this from In Progress to Done in Runtime / FRAME Jun 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
I5-tests Tests need fixing, improving or augmenting. Z1-easy Can be fixed primarily by duplicating and adapting code by an intermediate coder Z6-mentor An easy task where a mentor is available. Please indicate in the issue who the mentor could be.
Projects
Runtime / FRAME
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add test locking removed when amount is zero jpserrat/substrate
1 participant
@liamaharon