Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

beefy: add pruning for SetIdSession storage in pallet-beefy #13404

Closed
Tracked by #2462
acatangiu opened this issue Feb 17, 2023 · 0 comments · Fixed by #13411
Closed
Tracked by #2462

beefy: add pruning for SetIdSession storage in pallet-beefy #13404

acatangiu opened this issue Feb 17, 2023 · 0 comments · Fixed by #13411
Assignees
@acatangiu
Labels
I8-footprint An enhancement to provide a smaller (system load, memory, network or disk) footprint. U2-some_time_soon Issue is worth doing soon. Z1-easy Can be fixed primarily by duplicating and adapting code by an intermediate coder

Comments

@acatangiu
Copy link
Contributor

In pallet-beefy we keep a mapping of set id -> session index, this is necessary to validate equivocation proofs. The entries in this map are not being pruned.

We should bound the maximum number of entries in this mapping, for example GRANDPA pallet sets the limit to the bonding duration (in sessions).
@acatangiu acatangiu added I8-footprint An enhancement to provide a smaller (system load, memory, network or disk) footprint. U2-some_time_soon Issue is worth doing soon. Z1-easy Can be fixed primarily by duplicating and adapting code by an intermediate coder labels Feb 17, 2023
@acatangiu acatangiu self-assigned this Feb 17, 2023
@acatangiu acatangiu added this to BEEFY Feb 17, 2023
@acatangiu acatangiu mentioned this issue Aug 25, 2023
Closed
20 tasks
@acatangiu acatangiu moved this to Need for Kusama 🗒 in BEEFY Feb 17, 2023
@acatangiu acatangiu mentioned this issue Feb 17, 2023
Merged
@github-project-automation github-project-automation bot moved this from Need for Kusama 🗒 to Done ✅ in BEEFY Feb 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@acatangiu acatangiu

Labels
I8-footprint An enhancement to provide a smaller (system load, memory, network or disk) footprint. U2-some_time_soon Issue is worth doing soon. Z1-easy Can be fixed primarily by duplicating and adapting code by an intermediate coder
Projects
No open projects
BEEFY
Status: Done ✅
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

frame/beefy: prune entries in set id session mapping acatangiu/substrate
1 participant
@acatangiu