Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

MaxUnlockingChunks should be configurable via Runtime #12227

Closed
Ank4n opened this issue Sep 9, 2022 · 1 comment · Fixed by #12343
Closed

MaxUnlockingChunks should be configurable via Runtime #12227

Ank4n opened this issue Sep 9, 2022 · 1 comment · Fixed by #12343
Labels
I7-refactor Code needs refactoring. U2-some_time_soon Issue is worth doing soon. Z1-easy Can be fixed primarily by duplicating and adapting code by an intermediate coder Z6-mentor An easy task where a mentor is available. Please indicate in the issue who the mentor could be.

Comments

@Ank4n
Copy link
Contributor

Ank4n commented Sep 9, 2022 •
edited
Loading

StakingLedger in the pallet-staking is using a hardcoded value of MaxUnlockingChunks. Pallet-staking also has a MaxUnlockingChunks in the configuration which is not used anywhere.

I discussed this with @kianenigma, we should remove the hard coded value and use the value we get from Config.
@github-actions github-actions bot added the J2-unconfirmed Issue might be valid, but it’s not yet known. label Sep 9, 2022
@Ank4n Ank4n moved this to 📕 Backlog in (Nominated) Proof of Stake Sep 9, 2022
@Ank4n Ank4n added I7-refactor Code needs refactoring. U2-some_time_soon Issue is worth doing soon. Z6-mentor An easy task where a mentor is available. Please indicate in the issue who the mentor could be. Z1-easy Can be fixed primarily by duplicating and adapting code by an intermediate coder and removed J2-unconfirmed Issue might be valid, but it’s not yet known. labels Sep 9, 2022
@kianenigma kianenigma changed the title MaxUnlockingChunks should be configurable via Runtime MaxUnlockingChunks should be configurable via Runtime Sep 12, 2022
@MrishoLukamba
Copy link
Contributor

Taking it

@MrishoLukamba MrishoLukamba mentioned this issue Sep 18, 2022
Closed
@Ank4n Ank4n mentioned this issue Sep 24, 2022
Merged
Repository owner moved this from 📕 Backlog to ✅ Done in (Nominated) Proof of Stake Sep 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
I7-refactor Code needs refactoring. U2-some_time_soon Issue is worth doing soon. Z1-easy Can be fixed primarily by duplicating and adapting code by an intermediate coder Z6-mentor An easy task where a mentor is available. Please indicate in the issue who the mentor could be.
Projects
(Nominated) Proof of Stake
Status: ✅ Done
Milestone
No milestone
2 participants
@Ank4n @MrishoLukamba