Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Remove multiply_by_rational #11477

Closed
gavofyork opened this issue May 19, 2022 · 4 comments · Fixed by #11598
Closed

Remove multiply_by_rational #11477

gavofyork opened this issue May 19, 2022 · 4 comments · Fixed by #11598
Labels
I7-refactor Code needs refactoring. Z1-easy Can be fixed primarily by duplicating and adapting code by an intermediate coder Z6-mentor An easy task where a mentor is available. Please indicate in the issue who the mentor could be.

Comments

@gavofyork
Copy link
Member

Everything that uses it should instead be moved to use multiply_by_rational_with_rounding. SignedRounding should be used whenever inputs/outputs may be negative.

@gavofyork gavofyork added the I7-refactor Code needs refactoring. label May 19, 2022
@shawntabrizi shawntabrizi added Z6-mentor An easy task where a mentor is available. Please indicate in the issue who the mentor could be. Z1-easy Can be fixed primarily by duplicating and adapting code by an intermediate coder labels May 19, 2022
@tifecool
Copy link
Contributor

I would like to attempt this issue if @Szegoo is dropping it.

Is SignedRounding a struct or function or will I just add my own logic to round the inputs/outputs?

@tifecool
Copy link
Contributor

tifecool commented May 23, 2022

From my understanding, we want to work with integers for input, decimals within the function then, at output, round either up or down to the nearest integer.

Is this correct? @gavofyork

@Szegoo
Copy link
Contributor

Szegoo commented May 23, 2022

@tifecool You can have the issue :)

@tifecool
Copy link
Contributor

Please see my prior comments @shawntabrizi @gavofyork

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
I7-refactor Code needs refactoring. Z1-easy Can be fixed primarily by duplicating and adapting code by an intermediate coder Z6-mentor An easy task where a mentor is available. Please indicate in the issue who the mentor could be.
Projects
None yet
4 participants