Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

openGov support #39

Closed
4 tasks done
Tracked by #78
kianenigma opened this issue Jan 16, 2023 · 11 comments
Closed
4 tasks done
Tracked by #78

openGov support #39

kianenigma opened this issue Jan 16, 2023 · 11 comments
Assignees

Comments

@kianenigma
Copy link

kianenigma commented Jan 16, 2023

I've raised this in DM a few weeks ago as well, but I am worried that it will be forgotten until the day that we upgrade Polkadot to open gov as well and there'd be no way to tip anymore.

To learn how to support this, all you have to do is follow more or less what I did here:

https://kusama.polkassembly.io/referenda/69

  1. open gov proposal with small spender
  2. submit preimage

@rzadp edits below

Things left to figure out

  • Exact tip values corresponding to small/medium/large prompts
  • Chain-specific decimals, maximum tips per track, etc - Polkadot vs Kusama
  • Uploading tip (referendum) description
    • Either a polkassembly Description (off-chain),
    • Or a Remark (on-chain)
  • Automatically detect whether the chain supports gov1 or opengov. Send proper one with a single command.
@kianenigma
Copy link
Author

ping on this ^^ Open gov is coming to Polkadot (PR already open) and is being removed from Kusama. This will stop working soon.

@parutger parutger self-assigned this Feb 17, 2023
@kianenigma
Copy link
Author

any updates on this?

@parutger
Copy link
Contributor

I think I figured out how to implement this, but I'm having some trouble creating a local testing setup for this. Can you help me, or do you know who can?

@mordamax mordamax assigned rzadp and unassigned parutger Apr 6, 2023
@rzadp
Copy link
Contributor

rzadp commented Apr 13, 2023

Hey @kianenigma, just letting know that I have picked up this issue.
I will be posting updates.

@rzadp
Copy link
Contributor

rzadp commented Apr 14, 2023

Hey @kianenigma @bkchr, do you have any preference on how the new bot prompt for OpenGov should work when it comes to the exact tip values?

The difference is that in OpenGov we have to configure the tip value ahead of time, whereas in gov1 it was outside of the scope of the tip bot.

I have two proposals:

Prompt Behaviour
/tip {small,medium,large} or /tip {small,big} The bot looks up a corresponding constant value
/tip <number> The bot proposes the tip with the given value, automatically picking the correct track (Small Tipper / Big Tipper)

@bkchr
Copy link
Member

bkchr commented Apr 14, 2023

Maybe all? Fixed numbers for small, medium and large and then also tipping some custom number.

@mordamax
Copy link
Contributor

@bkchr, with custom number it's clear, but with fixed - question: since the limits of small track are different per relay-chain, for small/medium/large what values would you suggest?

kusama small tipper: max 8.3 KSM - so

  • small: 2 KSM
  • medium: 5KSM
  • large: 8KSM

polkadot small tipper: 250 DOT

  • small: 20DOT
  • medium: 80DOT
  • large: 150DOT

or any other numbers?

@kianenigma
Copy link
Author

Suggested numbers make sense as prelude defaults, and then as basti said I think it should be reasonable to allow custom 42 to tip exactly this amount. I suppose you can still cap it to small tipper range.

@rzadp
Copy link
Contributor

rzadp commented Apr 26, 2023

Hey @kianenigma @bkchr, just letting know that:

  • The opengov changes have been implemented, so we'll be ready for the removal of treasury tips.
  • We also implemented the custom numeric value for the tips.
  • The changes are deployed to staging (not to production yet at the time of writing).

@bkchr
Copy link
Member

bkchr commented Apr 26, 2023

Nice! Ty for the update!

@rzadp
Copy link
Contributor

rzadp commented May 11, 2023

The changes are done and deployed to production.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants