Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Also check for Polkadot Address in User Profile #182

Closed
shawntabrizi opened this issue Oct 29, 2024 · 2 comments
Closed

[Feature] Also check for Polkadot Address in User Profile #182

shawntabrizi opened this issue Oct 29, 2024 · 2 comments

Comments

@shawntabrizi
Copy link
Member

shawntabrizi commented Oct 29, 2024

People in the Polkadot ecosystem constantly contributing might also have their address included in their profile.

For example like me:

image

This, for example, is the pattern needed for all Fellowship members to get their github verified.

It would be good that if we trigger a tip, that we can also check this user profile for the address, in case the user does not include it directly into their github pull request body.

This would be a fallback to the PR body check.

@mordamax
Copy link
Contributor

@shawntabrizi we already have that, but parsing it a bit differently - similar to a PR body
https://github.com/paritytech/substrate-tip-bot/blob/master/src/util.ts#L65
polkadot address: <ADDRESS>

Do you suggest to use this address regardless of prefix or something else?

@shawntabrizi
Copy link
Member Author

haha nice, sorry i didnt know.

thank you for thinking ahead for me :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants