BUG: Tip bot does not correctly use approvers list

[shawntabrizi]

Karim is part of the approvers list.

But the bot rejects his approval.

Is it potentially a problem with using the tip bot in a different org than paritytech?

[Bullrich]

First suggestion I would recommend is to remove him from the group and then add him again.

We faced a similar problem in the past where, for some unknown reason, a user appeared as a team member in the UI but not in the API.

[mordamax]

@KarimJedda please add a link
afair it was not a paritytech org, that could be a reason i guess

[shawntabrizi]

@mordamax here is the link to where this happened: polkadot-developers/bounties#1

[mutantcornholio]

According to GitHub, at the time of the comment, @KarimJedda still wasn't a member of team

[shawntabrizi]

Yo @mutantcornholio, the issue persists, and its not cool to just close the issue without solving the problems being reported.

[rzadp]

I believe that 404 is actually a 403 - no access to read that info from a different org.

We should either:

a) Create a separate tip-bot-approvers per each org.
b) Provide the bot deployment with some additional token with read access to paritytech's org teams.

[mutantcornholio]

I think we're just using the wrong token here

We're handling tip request with an installation octokitInstance that we use for replying in another org.

Here we're using that token to query if tipRequester is a member of parity.

Instead, we should either use this one, or if it doesn't work then get a different installation token for our org, just how we did it for non-parity one.

To query members of parity team we should always use parity installation, for replying to requests, we need to use token of installation to the org, from which request is coming from