From 83e76c21b3b177f6ef8313892034f9e80548fb5a Mon Sep 17 00:00:00 2001 From: Mara Broda Date: Thu, 19 Jan 2023 15:39:15 +0100 Subject: [PATCH 1/3] Update changelog template to use new T labels --- scripts/ci/changelog/README.md | 3 +-- scripts/ci/changelog/templates/changes_client.md.tera | 2 +- scripts/ci/changelog/templates/changes_misc.md.tera | 4 ++-- scripts/ci/changelog/templates/changes_runtime.md.tera | 2 +- scripts/ci/changelog/templates/high_priority.md.tera | 2 +- 5 files changed, 6 insertions(+), 7 deletions(-) diff --git a/scripts/ci/changelog/README.md b/scripts/ci/changelog/README.md index 2386f7c1b523..29c898b1d401 100644 --- a/scripts/ci/changelog/README.md +++ b/scripts/ci/changelog/README.md @@ -44,9 +44,8 @@ Currently, the considered labels are: - E4 => new host function - E2 => database migration - B0 => silent, not showing up -- B1-releasenotes (misc unless other labels) +- B1-note_worthy (misc unless other labels) - B5-client (client changes) -- B7-runtimenoteworthy (runtime changes) - T6-XCM Note that labels with the same letter are mutually exclusive. diff --git a/scripts/ci/changelog/templates/changes_client.md.tera b/scripts/ci/changelog/templates/changes_client.md.tera index 36fb6b9de686..5c911407ac90 100644 --- a/scripts/ci/changelog/templates/changes_client.md.tera +++ b/scripts/ci/changelog/templates/changes_client.md.tera @@ -9,7 +9,7 @@ {#- We skip silent ones -#} {%- else -%} - {%- if pr.meta.B.value == 5 and not pr.title is containing("ompanion") %} + {%- if pr.meta.T and pr.meta.T.value == 0 and not pr.title is containing("ompanion") %} - {{ m_c::change(c=pr) }} {%- endif -%} {% endif -%} diff --git a/scripts/ci/changelog/templates/changes_misc.md.tera b/scripts/ci/changelog/templates/changes_misc.md.tera index 3ad1e1d222b7..9c5662f70ae8 100644 --- a/scripts/ci/changelog/templates/changes_misc.md.tera +++ b/scripts/ci/changelog/templates/changes_misc.md.tera @@ -7,7 +7,7 @@ {%- if pr.meta.B.value == 0 -%} {#- We skip silent ones -#} {%- else -%} - {%- if pr.meta.B and pr.meta.B.value != 5 and pr.meta.B.value != 7 or pr.meta.C or not pr.meta.B %} + {%- if pr.meta.T and pr.meta.T.value == 0 %} {%- set_global misc_count = misc_count + 1 -%} {%- endif -%} {% endif -%} @@ -27,7 +27,7 @@ There are other misc. changes. You can expand the list below to view them all. {%- if pr.meta.B.value == 0 %} {#- We skip silent ones -#} {%- else -%} - {%- if pr.meta.B and pr.meta.B.value != 5 and pr.meta.B.value != 7 or pr.meta.C or not pr.meta.B %} + {%- if pr.meta.T and pr.meta.T.value == 0 %} - {{ m_c::change(c=pr) }} {%- endif -%} {% endif -%} diff --git a/scripts/ci/changelog/templates/changes_runtime.md.tera b/scripts/ci/changelog/templates/changes_runtime.md.tera index 67da1ebbc394..db7f6bff1111 100644 --- a/scripts/ci/changelog/templates/changes_runtime.md.tera +++ b/scripts/ci/changelog/templates/changes_runtime.md.tera @@ -10,7 +10,7 @@ {#- We skip silent ones -#} {%- else -%} -{%- if pr.meta.B.value == 7 and not pr.title is containing("ompanion") %} +{%- if pr.meta.T and pr.meta.T.value == 1 and not pr.title is containing("ompanion") %} - {{ m_c::change(c=pr) }} {%- endif -%} {%- endif -%} diff --git a/scripts/ci/changelog/templates/high_priority.md.tera b/scripts/ci/changelog/templates/high_priority.md.tera index 117d335efdc0..aabc9f01f628 100644 --- a/scripts/ci/changelog/templates/high_priority.md.tera +++ b/scripts/ci/changelog/templates/high_priority.md.tera @@ -25,7 +25,7 @@ The changes motivating this priority level are: {%- if pr.meta.C -%} {%- if pr.meta.C.value == p %} - {{ m_c::change(c=pr) }} -{%- if pr.meta.B and pr.meta.B.value == 7 %} (RUNTIME) +{%- if pr.meta.T and pr.meta.T.value == 1 %} (RUNTIME) {% endif %} {%- endif -%} {%- endif -%} From f6bb84c1ced0ceb38f8505a3ac60c87b2e60be5f Mon Sep 17 00:00:00 2001 From: Mara Broda Date: Thu, 19 Jan 2023 15:42:11 +0100 Subject: [PATCH 2/3] update readme --- scripts/ci/changelog/README.md | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/scripts/ci/changelog/README.md b/scripts/ci/changelog/README.md index 29c898b1d401..80795438b100 100644 --- a/scripts/ci/changelog/README.md +++ b/scripts/ci/changelog/README.md @@ -44,9 +44,9 @@ Currently, the considered labels are: - E4 => new host function - E2 => database migration - B0 => silent, not showing up -- B1-note_worthy (misc unless other labels) -- B5-client (client changes) -- T6-XCM +- B1 => noteworthy +- T0 => node +- T1 => runtime Note that labels with the same letter are mutually exclusive. A PR should not have both `B0` and `B5`, or both `C1` and `C9`. In case of conflicts, the template will From 49c9e8aa68f87249fba0370675e7b9543b5d8e56 Mon Sep 17 00:00:00 2001 From: Mara Broda Date: Thu, 19 Jan 2023 15:44:09 +0100 Subject: [PATCH 3/3] changelog gen: remove T6 --- scripts/ci/changelog/templates/change.md.tera | 5 ----- 1 file changed, 5 deletions(-) diff --git a/scripts/ci/changelog/templates/change.md.tera b/scripts/ci/changelog/templates/change.md.tera index 432b93eb687d..6d133439e2e9 100644 --- a/scripts/ci/changelog/templates/change.md.tera +++ b/scripts/ci/changelog/templates/change.md.tera @@ -33,10 +33,5 @@ {%- set repo = " " -%} {%- endif -%} -{%- if c.meta.T and c.meta.T.value == 6 -%} -{%- set xcm = " [✉️ XCM]" -%} -{%- else -%} -{%- set xcm = "" -%} -{%- endif -%} {{- repo }} {{ audit }}[`#{{c.number}}`]({{c.html_url}}) {{- prio }} - {{ c.title | capitalize | truncate(length=120, end="…") }}{{xcm }} {%- endmacro change -%}