Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Availability Store should use determine_new_blocks on import notifications #3300

Closed
rphmeier opened this issue Jun 18, 2021 · 0 comments · Fixed by #3356
Closed

Availability Store should use determine_new_blocks on import notifications #3300

rphmeier opened this issue Jun 18, 2021 · 0 comments · Fixed by #3356
Labels
I8-refactor Code needs refactoring.

Comments

@rphmeier
Copy link
Contributor

rphmeier commented Jun 18, 2021

These logs: "Candidate included without being backed?", can stem from missing block import notifications and CandidateEvent::Backed. Missing these and other candidate events will lead to storage leaks over time as well.

#3261 implements a utility for backwards iteration, so it should be easy to plug this into the availability store now.

The only thing is that it relies on both a lower bound number and an is_known function which might need some changes in the av-store schema.

@rphmeier rphmeier added the I8-refactor Code needs refactoring. label Jun 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
I8-refactor Code needs refactoring.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant