From a0f1fa3d9d0dc4596dfaa480e0831057e913269a Mon Sep 17 00:00:00 2001 From: Andrei Eres Date: Mon, 11 Nov 2024 11:37:30 +0100 Subject: [PATCH 1/3] Remove debug message about pruning active leaves --- polkadot/node/core/pvf/src/execute/queue.rs | 2 -- 1 file changed, 2 deletions(-) diff --git a/polkadot/node/core/pvf/src/execute/queue.rs b/polkadot/node/core/pvf/src/execute/queue.rs index 6d27ab0261d98..69355b8fd55df 100644 --- a/polkadot/node/core/pvf/src/execute/queue.rs +++ b/polkadot/node/core/pvf/src/execute/queue.rs @@ -305,8 +305,6 @@ impl Queue { for hash in &update.deactivated { let _ = self.active_leaves.remove(&hash); } - - gum::debug!(target: LOG_TARGET, size = ?self.active_leaves.len(), "Active leaves pruned"); } fn insert_active_leaf(&mut self, update: ActiveLeavesUpdate, ancestors: Vec) { From fa21eeda6b15de66a9c004aa9ed6bdc9905d4d32 Mon Sep 17 00:00:00 2001 From: GitHub Action Date: Tue, 12 Nov 2024 18:26:24 +0000 Subject: [PATCH 2/3] Update from AndreiEres running command 'prdoc --audience node_dev --bump silent --description Removed useless debug message' --- prdoc/pr_6440.prdoc | 15 +++++++++++++++ 1 file changed, 15 insertions(+) create mode 100644 prdoc/pr_6440.prdoc diff --git a/prdoc/pr_6440.prdoc b/prdoc/pr_6440.prdoc new file mode 100644 index 0000000000000..5d5b0d77248b3 --- /dev/null +++ b/prdoc/pr_6440.prdoc @@ -0,0 +1,15 @@ +title: Remove debug message about pruning active leaves +doc: +- audience: Node Dev + description: |- + # Description + + The debug message was added to identify a potential memory leak. However, recent observations show that pruning works as expected. Therefore, it is best to remove this line, as it generates quite annoying logs. + + + ## Integration + + Doesn't affect downstream projects. +crates: +- name: polkadot-node-core-pvf + validate: false From 43ac2dc166ccb4e81234fc6c169fa42eb75a9f1d Mon Sep 17 00:00:00 2001 From: Andrei Eres Date: Wed, 13 Nov 2024 09:27:03 +0100 Subject: [PATCH 3/3] Update prdoc --- prdoc/pr_6440.prdoc | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/prdoc/pr_6440.prdoc b/prdoc/pr_6440.prdoc index 5d5b0d77248b3..376e59fa752eb 100644 --- a/prdoc/pr_6440.prdoc +++ b/prdoc/pr_6440.prdoc @@ -2,14 +2,7 @@ title: Remove debug message about pruning active leaves doc: - audience: Node Dev description: |- - # Description - - The debug message was added to identify a potential memory leak. However, recent observations show that pruning works as expected. Therefore, it is best to remove this line, as it generates quite annoying logs. - - - ## Integration - - Doesn't affect downstream projects. + Removed useless debug message crates: - name: polkadot-node-core-pvf validate: false