From e64fba7d0f21785763dd5ad1ac1fb4be4a6c3911 Mon Sep 17 00:00:00 2001
From: muharem <ismailov.m.h@gmail.com>
Date: Thu, 14 Sep 2023 12:38:46 +0200
Subject: [PATCH] pass asset id as ref for ConversionFromAssetBalance

---
 substrate/frame/asset-rate/src/lib.rs             | 2 +-
 substrate/frame/asset-rate/src/tests.rs           | 4 ++--
 substrate/frame/support/src/traits/tokens/misc.rs | 2 +-
 3 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/substrate/frame/asset-rate/src/lib.rs b/substrate/frame/asset-rate/src/lib.rs
index c3dc551f876d0..2b154070a1db8 100644
--- a/substrate/frame/asset-rate/src/lib.rs
+++ b/substrate/frame/asset-rate/src/lib.rs
@@ -234,7 +234,7 @@ where
 
 	fn from_asset_balance(
 		balance: BalanceOf<T>,
-		asset_kind: AssetKindOf<T>,
+		asset_kind: &AssetKindOf<T>,
 	) -> Result<BalanceOf<T>, pallet::Error<T>> {
 		let rate = pallet::ConversionRateToNative::<T>::get(asset_kind)
 			.ok_or(pallet::Error::<T>::UnknownAssetKind.into())?;
diff --git a/substrate/frame/asset-rate/src/tests.rs b/substrate/frame/asset-rate/src/tests.rs
index 452265476093b..0a7f2b32e4a19 100644
--- a/substrate/frame/asset-rate/src/tests.rs
+++ b/substrate/frame/asset-rate/src/tests.rs
@@ -135,7 +135,7 @@ fn convert_works() {
 			BalanceOf<Test>,
 			<Test as pallet_asset_rate::Config>::AssetKind,
 			BalanceOf<Test>,
-		>>::from_asset_balance(10, ASSET_ID);
+		>>::from_asset_balance(10, &ASSET_ID);
 		assert_eq!(conversion.expect("Conversion rate exists for asset"), 25);
 	});
 }
@@ -147,7 +147,7 @@ fn convert_unknown_throws() {
 			BalanceOf<Test>,
 			<Test as pallet_asset_rate::Config>::AssetKind,
 			BalanceOf<Test>,
-		>>::from_asset_balance(10, ASSET_ID);
+		>>::from_asset_balance(10, &ASSET_ID);
 		assert!(conversion.is_err());
 	});
 }
diff --git a/substrate/frame/support/src/traits/tokens/misc.rs b/substrate/frame/support/src/traits/tokens/misc.rs
index 84bbe3e8d9c83..d042d20d4d61c 100644
--- a/substrate/frame/support/src/traits/tokens/misc.rs
+++ b/substrate/frame/support/src/traits/tokens/misc.rs
@@ -270,7 +270,7 @@ pub trait ConversionFromAssetBalance<AssetBalance, AssetId, OutBalance> {
 	type Error;
 	fn from_asset_balance(
 		balance: AssetBalance,
-		asset_id: AssetId,
+		asset_id: &AssetId,
 	) -> Result<OutBalance, Self::Error>;
 }