Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix parsing of companion reference line in PR description #39

Closed
joao-paulo-parity opened this issue May 11, 2022 · 0 comments · Fixed by #42
Closed

Fix parsing of companion reference line in PR description #39

joao-paulo-parity opened this issue May 11, 2022 · 0 comments · Fixed by #42
Labels
bug Something isn't working

Comments

@joao-paulo-parity
Copy link
Contributor

Problem: The pull request template of Substrate (example: paritytech/substrate#11392) has the expression "Polkadot companion:" which incorrectly gets interpreted as a companion reference

if [[ "$line" =~ [cC]ompanion:[[:space:]]*([^[:space:]]+) ]]; then

Solution: improve the regular expression to not misdetect such cases. Perhaps ^[^[:space:]]+[[:space:]]+[cC]ompanion:[[:space:]]*([^[:space:]]+)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant