This repository was archived by the owner on Nov 6, 2020. It is now read-only.
Read registry_address from given block #7866
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svyatonik
added
A0-pleasereview 🤓
5chdn
added
A8-looksgood 🦄
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In brief: before reacting to contract events (like serving key generation requests in SS) we might want to wait for several confirmations. But the similar situation is with the contract itself - there might be a reorg to previous/other address within a few blocks. So it is a good idea to rely on the address from the same block we're reading requests from.
Original TODO: https://github.com/paritytech/parity/blob/fab03398dda7e768b1b620c07bf82cbfed662fa8/secret_store/src/listener/service_contract.rs#L128 will be fixed later if this PR will be accepted.